-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dz 2 #3
base: master
Are you sure you want to change the base?
Dz 2 #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Переработать согласно разбору ДЗ
left: 7px; | ||
} | ||
|
||
.todo-item_checkbox input[type="checkbox"] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Не нужно использовать селекторы по тегу. Используем класс
visibility: hidden; | ||
} | ||
|
||
.todo-item_checkbox input[type="checkbox"]::before { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Синхронизировать с разбором в ДЗ
} | ||
|
||
.todo-item:hover .todo-item_remove { | ||
opacity: 0.7; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Как навести на элемент который невидим?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DmitryMakhnev так opacity же не 0, значит он видим, разве нет?)
overflow: hidden; | ||
} | ||
|
||
.__ready textarea { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Нельзя использовать селектор по модификатору вне контекста блока
styles/base/todo-item/todo-item.css
Outdated
@@ -0,0 +1,6 @@ | |||
.todo-item { | |||
display: block; | |||
height: 50px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Высота должна быть динамической
@@ -0,0 +1,16 @@ | |||
.todos-filter { | |||
background-color: inherit; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
В таком случае непонятно откуда возьмётся цвет
} | ||
|
||
.todos-filter:hover { | ||
background-color: #fafafa; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Вроде бы на ховер не было каких-то стилей
@@ -0,0 +1,9 @@ | |||
.todos-add_input { | |||
font-style: italic; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Italic только для плейсхолдера см https://css-tricks.com/almanac/selectors/p/placeholder/
|
||
.todos-step1 { | ||
margin: 0 1%; | ||
width: 98%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ширину указывать не надо
Отступы указать в пикселях
styles/reset.css
Outdated
@@ -0,0 +1,11 @@ | |||
* { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Использовать reset из репозитория с препроцессорами
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Пофиксить замечания
public/index.html
Outdated
<div class="todos-workspace"> | ||
<div class="todos-add"> | ||
<button class="todos-add_select-all" aria-label="Отметить как выполненные все"></button> | ||
<input class="todos-add_input" placeholder="What needs to be done?" aria-label="Поле добавления todo"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Без обёртки будет криво, смотрите разбор дз
@@ -0,0 +1,90 @@ | |||
@import "../../config/globals"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo-item не базовый блок
} | ||
|
||
.todo-item_checkbox { | ||
position: absolute; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo item должен быть свёрстан на флоатах и флексах, см разбор дз
top: 0; | ||
width: 100%; | ||
height: 100%; | ||
z-index: 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Эти стили должны быть в базовом блоке чекбокса
public/index.html
Outdated
<div class="todo-item"> | ||
<div class="todo-item_checkbox"> | ||
<input type="checkbox" | ||
class="todo-item_checkbox_target" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Не правильная структура чекбокса, смотрите разбор дз
color: $c-gray; | ||
border: none; | ||
box-sizing: border-box; | ||
width: 100%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Тоже не правильно, решение должно быть на флоатах, проблемы решения на абсолютах, я раскрывал на лекциях
No description provided.