Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test for invalid HTTPS cert #6

Open
dionyziz opened this issue Oct 21, 2014 · 4 comments
Open

Unit test for invalid HTTPS cert #6

dionyziz opened this issue Oct 21, 2014 · 4 comments
Assignees

Comments

@dionyziz
Copy link
Member

dionyziz commented Oct 21, 2014

As this is security-related software, I recommend we add a test to check that when connecting to a DNSChain server via HTTPS with an invalid certificate, the connection is rejected client-side with an appropriate error.

May need to mock this properly.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/5422412-unit-test-for-invalid-https-cert?utm_campaign=plugin&utm_content=tracker%2F7170449&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F7170449&utm_medium=issues&utm_source=github).
@zancas
Copy link
Contributor

zancas commented Oct 22, 2014

I'll take this.

@zancas zancas self-assigned this Oct 22, 2014
@taoeffect
Copy link
Member

@taoeffect
Copy link
Member

Also, DNSChain will need to add HTTPS support first (easy to do though, I can do it in a few days, or someone else can do it faster).

@zancas
Copy link
Contributor

zancas commented Oct 22, 2014

I won't commit to adding HTTPS support to DNSChain, but maybe if I'm really productive, I can get around to to it after adding fingerprint verification to the pydnschain node. Anywho, if no-one else's has gotten to it by the time I've polished off the rest of my issues, I'll start on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants