-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Filetree context menu #528
Conversation
Deploying opendataeditor with Cloudflare Pages
|
dfffd8b
to
4c1d01f
Compare
…itor into 511-context-menu
This is looking good @guergana !! The "Do not show this again" does not seem to work. It keeps appearing every time I upload a file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked it on Mac. I agree that there is still something going on the context menu within folders.
There is another problem. Faith adapted the original context menu to make it more generic (check comment added on the ticket a couple of weeks ago). We need to implement the generic option because we will have inconsistencies, like this one:
What I did for this case is to open the folder. @romicolman I have pushed a new commit with this solution: What do you think? |
0a45ff5
to
21eeb7f
Compare
Hi! I think there is a confusion. Right now, I see this:
The description creates confusion since we are distinguishing between folders and files in the app and in the sentence we are mixing both elements (The ODE FOLDER where this FILE exists)
Again, mixed language. This is my suggestion: Add the same text for context menu on files and folders:
|
oh, yes, i missed one of the names. @romicolman could you check again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good! Thanks!!
Note: since the context menu conflicts design-wise with the multiselect, we will disable it in #543