Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

527 remove shortcuts #530

Merged
merged 3 commits into from
Sep 4, 2024
Merged

527 remove shortcuts #530

merged 3 commits into from
Sep 4, 2024

Conversation

pdelboca
Copy link
Member

It also adds a cursor: pointer to the elements.


Please make sure that all the checks pass. Please add here any additional information regarding this pull request. It's highly recommended that you link this PR to an issue (please create one if it doesn't exist for this PR)

Copy link

cloudflare-workers-and-pages bot commented Aug 27, 2024

Deploying opendataeditor with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0d7348e
Status: ✅  Deploy successful!
Preview URL: https://d710a511.opendataeditor.pages.dev
Branch Preview URL: https://527-remove-shortcuts.opendataeditor.pages.dev

View logs

@pdelboca pdelboca requested a review from guergana August 27, 2024 10:46
@guergana
Copy link
Collaborator

Hi, @pdelboca this PR is only removing the visual part, but the shortcuts are still implemented here: https://github.com/okfn/opendataeditor/blob/main/client/components/Application/Dialogs/FileUpload.tsx#L103

Copy link
Collaborator

@guergana guergana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @pdelboca this PR is only removing the visual part, but the shortcuts are still implemented here: https://github.com/okfn/opendataeditor/blob/main/client/components/Application/Dialogs/FileUpload.tsx#L103

Copy link
Collaborator

@guergana guergana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ 💯

@pdelboca pdelboca merged commit 96bb94b into main Sep 4, 2024
9 checks passed
@pdelboca pdelboca deleted the 527-remove-shortcuts branch September 4, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove shortcuts from the ADD feature
2 participants