Make changes to datagrid

[guergana]

• fixes Changes to the datagrid #520

[guergana]

@pdelboca @romicolman the metadata panel now shows below the screen, i think before it was absolutely positioned. I am not sure if this belongs to this ticket. Maybe that was introduced when we made changes from flex to grid system?

As you can see in the screenshot, now the user has to scroll to see the metadata panel. Before it was overlayed:

[pdelboca]

@guergana we dicussed the issue with the metadata in the comments of this issue: #520 (comment)

I think it would be nice to fix it here since we are implementing changes in the datagrid and the layout. Does it makes sense?

[romicolman]

Hi @guergana! I tested changes. Here are a few comments:

1. Just in case... are the font and size of the buttons Metadata, source, errors report, undo and redo and table cells aligned with the new design?

2. I know we removed tooltips from the datagrid and changes were implemented OK, but I can see them on the Publish and Save changes buttons now that we moved those features:

• I asked @faith to indicate if we will keep the red color (errors) as it is or if we need to adapt it (see comment on the issue). @Faithkenny can add a comment in the ticket so that Guergana can make changes if needed?

[guergana]

Hi @guergana! I tested changes. Here are a few comments:

1. Just in case... are the font and size of the buttons **Metadata, source, errors report, undo and redo** and table cells aligned with the new design?

2. I know we removed tooltips from the datagrid and changes were implemented OK, but  I can see them on the Publish and Save changes buttons now that we moved those features:

* I asked @faith to indicate if we will keep the red color (errors) as it is or if we need to adapt it ([see comment on the issue](https://github.com/okfn/opendataeditor/issues/520)). @Faithkenny can add a comment in the ticket so that Guergana can make changes if needed?

Hi @romicolman I tried to make a compromise between the buttons we currently have, as @pdelboca has been pointing out, and the design, since these buttons don't exist in the current code. I have removed the tooltips. :)

[guergana]

@guergana we dicussed the issue with the metadata in the comments of this issue: #520 (comment)

I think it would be nice to fix it here since we are implementing changes in the datagrid and the layout. Does it makes sense?

Yes, sure @pdelboca

[cloudflare-workers-and-pages]

Deploying opendataeditor with    Cloudflare Pages

Latest commit:	4641443
Status:	✅  Deploy successful!
Preview URL:	https://2046de07.opendataeditor.pages.dev
Branch Preview URL:	https://520-datagrid.opendataeditor.pages.dev

View logs

[guergana]

@guergana we dicussed the issue with the metadata in the comments of this issue: #520 (comment)

I think it would be nice to fix it here since we are implementing changes in the datagrid and the layout. Does it makes sense?

@romicolman @pdelboca the panel position is fixed now.

@Faithkenny the color of the column with errors in the datagrid is OKFNRed now.

Please review again everyone and let me know if further changes are needed.

[romicolman]

Hi @guergana! I have just tested changes:

1. Te metadata and errors panel now look good.
2. Tooltips have been removed.
3. Faith added indications in terms of the red color to show errors. I still see the old one:

If this is not a small change, please, let's work on it after the pre-release.

[guergana]

Hi @guergana! I have just tested changes:

1. Te metadata and errors panel now look good.

2. Tooltips have been removed.

3. Faith added indications in terms of the red color to show errors. I still see the old one:

If this is not a small change, please, let's work on it after the pre-release.

It's done, please check again.

[romicolman]

I'm seeing the same color. Maybe the problem is connected to Mac?

[romicolman]

I checked it again and I can see the new color on the datagrid