Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename column functionality #595

Merged
merged 10 commits into from
Oct 17, 2024
Merged

Conversation

roll
Copy link
Collaborator

@roll roll commented Oct 11, 2024


After deep investigation the conclusion was that it's basically impossible to keep all the editing functionality at the same time without falling into a rabbit hole and unmaintainable code. There are data changes, metadata changes, undo, redo + this feature requires special kind of changes -- DDL command on the database that affects both data and metadata.

I think the only robust solution is what is implemented in this PR:

  • disabled field name editing in metadata
  • disabled adding new fields in metadata (needs a new feature on the data grid -- create issue)
  • disabled removing new fields in metadata (needs a new feature on the data grid -- create issue)
  • column renaming is implemented a separate action available in the data grid
  • currently, the column context menu is used because clicking on the column name does ordering

ode

@roll roll requested a review from guergana October 11, 2024 13:05
@romicolman
Copy link
Collaborator

@roll Basically, since the table headers are link to the filter feature, it is not possible to make column names editable, right? If that's the case, I think it is important to keep field name editing in metadata.

@roll
Copy link
Collaborator Author

roll commented Oct 14, 2024

@romicolman
Let's discuss it in the standup. It can be different kinds of UI (currently, it's a part of context menu) so different options are possible. What is really almost impossible is to keep it as part of metadata as this change requires to be atomic instead of being a part of change history

@romicolman
Copy link
Collaborator

romicolman commented Oct 14, 2024

OK! Perfect. Let's talk about it today.

@romicolman
Copy link
Collaborator

@roll let's go with this approach: add the Rename category to the filter, disable field name editing in metadata. I'll create separate issues for the rest of the changes we need to implement :)

@roll
Copy link
Collaborator Author

roll commented Oct 15, 2024

Thanks!

@guergana
Copy link
Collaborator

Thanks!

@roll is this PR ready for review now after the changes asked from Romina? 👀

@roll
Copy link
Collaborator Author

roll commented Oct 16, 2024

@guergana
Yes

@guergana
Copy link
Collaborator

guergana commented Oct 16, 2024

@roll excellent work. I like the context menu solution. Maybe we should more functions to the context menu. It seems more intuitive and easier to understand than having to navigate to the metadata panel.

@roll
Copy link
Collaborator Author

roll commented Oct 17, 2024

Thanks!

@roll roll merged commit 23fbe47 into main Oct 17, 2024
9 checks passed
@roll roll deleted the 574/sync-data-header-with-metadata-take-2 branch October 17, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Column name is not updated after changing it in the metadata panel Ability to edit header/labels
3 participants