-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename column functionality #595
Conversation
@roll Basically, since the table headers are link to the filter feature, it is not possible to make column names editable, right? If that's the case, I think it is important to keep field name editing in metadata. |
@romicolman |
OK! Perfect. Let's talk about it today. |
@roll let's go with this approach: add the Rename category to the filter, disable field name editing in metadata. I'll create separate issues for the rest of the changes we need to implement :) |
Thanks! |
@roll is this PR ready for review now after the changes asked from Romina? 👀 |
@guergana |
@roll excellent work. I like the context menu solution. Maybe we should more functions to the context menu. It seems more intuitive and easier to understand than having to navigate to the metadata panel. |
Thanks! |
After deep investigation the conclusion was that it's basically impossible to keep all the editing functionality at the same time without falling into a rabbit hole and unmaintainable code. There are data changes, metadata changes, undo, redo + this feature requires special kind of changes -- DDL command on the database that affects both data and metadata.
I think the only robust solution is what is implemented in this PR: