Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish dialog #602

Merged
merged 11 commits into from
Oct 23, 2024
Merged

Publish dialog #602

merged 11 commits into from
Oct 23, 2024

Conversation

guergana
Copy link
Collaborator


This PR implements exclusively the 'Publish' dialog

@guergana guergana changed the title 526 publish dialog [WiP] Publish dialog Oct 15, 2024
@guergana guergana changed the base branch from main to 526-adapt-dialogs October 15, 2024 20:07
Copy link

cloudflare-workers-and-pages bot commented Oct 16, 2024

Deploying opendataeditor with  Cloudflare Pages  Cloudflare Pages

Latest commit: b1b6cb6
Status: ✅  Deploy successful!
Preview URL: https://f4ae6b20.opendataeditor.pages.dev
Branch Preview URL: https://526-publish-dialog.opendataeditor.pages.dev

View logs

@guergana guergana changed the title [WiP] Publish dialog Publish dialog Oct 16, 2024
@roll
Copy link
Collaborator

roll commented Oct 18, 2024

@guergana
Looks good!

But what is this? =)

Screenshot from 2024-10-18 10-18-04

It might be help messages that needs to be written for publish editors

@guergana
Copy link
Collaborator Author

@guergana
Looks good!

But what is this? =)

Screenshot from 2024-10-18 10-18-04

It might be help messages that needs to be written for publish editors

Hi @roll this is part of the design. 😅 I am not sure I understand your question.

@roll
Copy link
Collaborator

roll commented Oct 19, 2024

I mean the message itself is random not related to publishing. I guess it's because it was just bootstrapped but never written as it wasn't visible previously.

It might need a follow-up issue to fix it

@guergana
Copy link
Collaborator Author

guergana commented Oct 19, 2024

I mean the message itself is random not related to publishing. I guess it's because it was just bootstrapped but never written as it wasn't visible previously.

It might need a follow-up issue to fix it

@roll I don't understand what is there to fix. This message is part of this ticket. Do you mean the text doesn't make any sense? Yeah, we probably need to ask @Faithkenny or @romicolman about the text, if this is what you mean.

@roll
Copy link
Collaborator

roll commented Oct 19, 2024

@guergana
I think it's fine for this PR as a re-design one.

What I'm saying is that this file needs to be filled with correct help messages - https://github.com/okfn/opendataeditor/blob/main/client/components/Editors/Portal/help.yaml - e.g. "User -- a github username you can find in your Github account", "Repo - ..." etc. @romicolman something not to forget as a follow-up

@guergana
Copy link
Collaborator Author

@guergana
I think it's fine for this PR as a re-design one.

What I'm saying is that this file needs to be filled with correct help messages - https://github.com/okfn/opendataeditor/blob/main/client/components/Editors/Portal/help.yaml - e.g. "User -- a github username you can find in your Github account", "Repo - ..." etc. @romicolman something not to forget as a follow-up

I can include them here also once I have text of the messages. @romicolman @roll or follow up PR is also fine.

Base automatically changed from 526-adapt-dialogs to main October 21, 2024 15:56
@guergana guergana merged commit c28a359 into main Oct 23, 2024
9 checks passed
@guergana guergana deleted the 526-publish-dialog branch October 23, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt dialogs to the new UI
2 participants