Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support release with incomplete date #76

Open
CrendKing opened this issue Sep 29, 2022 · 0 comments
Open

Support release with incomplete date #76

CrendKing opened this issue Sep 29, 2022 · 0 comments

Comments

@CrendKing
Copy link

CrendKing commented Sep 29, 2022

For instance, release 2e6374f8-420b-353b-8c42-dbb249bfac1c's date is simply "1984" without the month and day. When retrieved with this crate, it is converted to a NaiveDate with value "1984-01-01", supposedly due to this logic. Doesn't seem to have a way to restore the original "1984" value.

Sure, we can heuristically say if the date's month and day are both 1, most likely they can be discarded. But there could be case where the release date is really on the new year's day.

Maybe instead of deserialize the date to a NaiveDate, simply keep it as String, and let user choose which library to use?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant