feat: add LTR-RTL button to support rtl languages #1927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganeshsomasundaram-okta
requested review from
KevinGhadyani-Okta,
kamronbatmanghelich-okta and
a team
as code owners
kamronbatmanghelich-okta
approved these changes
Aug 8, 2023
KevinGhadyani-Okta
added a commit
that referenced
this pull request
Aug 28, 2023
* refactor(odyssey-design-tokens): consolidate tokens, initial 2.0 work * refactor(odyssey-react-mui): refactor to use new tokens * refactor(odyssey-storybook): refactor to use new tokens * chore: pr feedback * refactor: update token names based on Content feedback * refactor: update typography tokens to match new values * fix(odyssey-storybook): match storybook ui to new tokens * chore: these keep popping up after build * docs(odyssey-storybook): update theming docs to use new tokens * Translations for odyssey (#1807) chore(odyssey-react-mui): translations for odyssey-react-mui.properties * fix: use odyssey tokens inside mui components style override * refactor(odyssey-design-tokens): rename "primary" type color to "action" * feat(odyssey-design-tokens): add "darker" to primary palette * feat(odyssey-react-mui): update Link to match new brand standards * feat(odyssey-react-mui): include color properties in type styles * refactor(odyssey-react-mui): migrate Circular Progress to design tokens * chore: fix hover/visited ordering * chore: same fix for monochrome variant * fix: add incremental to root tsconfig (#1810) fix: added incremental to root TSconfig * feat(odyssey-design-tokens): add border.radius.round * refactor(odyssey-design-tokens): caution to warning * refactor(odyssey-react-mui): convert MuiChip to odyssey tokens; find/replace all touched tokens * fix: memoize the Link component (#1813) fix: memoized the Link component * feat(odyssey-design-tokens): add border.width.heavy * feat(odyssey-react-mui): update Status styles and variants to match brand * docs(odyssey-storybook): update Status stories * feat(odyssey-design-tokens): add tokens for colorized text * refactor(odyssey-react-mui): apply colorized text tokens * chore: upgraded Applitools (#1815) * fix: change to DesignTokens type rather than the overrides in theme (#1816) * fix: changed to DesignTokens type rather than the overrides in theme creation * fix: incorrectly named property in Odyssey Storybook theme issue * chore(odyssey-design-tokens): update hue values * chore: rename indicator to variant * feat(odyssey-design-tokens): add 'disabled' type color * feat(odyssey-react-mui): add icon support to Tag * fix(odyssey-react-mui): add aria-disabled to Tag * chore: update Tag and Status styles based on design feedback * fix: orrectly import zh-CN and zh-TW files * refactor: remove isDefaultChecked and add isInvalid to Radio * refactor: remove vestigial isDefaultChecked from Checkbox * refactor: remove isDefaultValue from Radio * refactor: change hasError to isInvalid for Radio * refactor: make default Tooltip placement top * feat(odyssey-design-tokens): add border.outer and palette.x.heading * refactor(odyssey-react-mui): update all Alert styles to match rebrand * fix: enable a11y tests in CI (#1826) * fix: enable a11y tests in CI, add ariaLabel to components with accessibility violations * refactor(odyssey-react-mui): refactor alert title styling to enable variation * fix: Applitools VRT (#1827) fix: fixed Applitools config * feat(odyssey-design-tokens): add alpha tokens * feat(odyssey-react-mui): add transparency and blur to Toast * chore(odyssey-design-tokens): update alpha values to hex * docs(odyssey-storybook): make datepicker starting date fixed * chore: fix borderRadius on banner * chore(deps-dev): bump vite from 4.3.8 to 4.3.9 (#1819) Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 4.3.8 to 4.3.9. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v4.3.9/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix: clicking MenuItem closes MenuButton (#1820) * fix: clicking MenuItem didn't close MenuButton * fix: incorrect prop name in MenuButton stories * Fix RTL position of chevron in NativeSelect (#1835) fix: adjust NativeSelect chevron position in RTL * Remove default branch in i18n config (#1841) * docs(odyssey-storybook): update Form stories to be more comprehensive * feat(odyssey-design-tokens): add token for border.radius.tight * feat(odyssey-react-mui): add sub2 type style * refactor(odyssey-react-mui): update Form and Fieldset styles to match brand * chore: add Checkbox to kitchen sink * fix: specfy accessibility tags section508, wcag21aa (#1839) * fix: specfy accessibility tags section508, wcag21aa * fix: a11y test for toast, typography, radio, checkbox * chore: update Field margin * RTL fixes for field labels (#1836) * fix: respect RTL in FormControlLabel children * fix: respect RTL in FormLabel optional text * refactor: replace margins with gap * refactor: remove vestigial display declaration * Enable button wrapping in Dialog footer (#1838) * feat: enable button wrapping in Dialog footer * refactor: improve Dialog footer specificity * Add missing displayNames to components (#1852) refactor: add missing displayNames * refactor(odyssey-react-mui): use component class name variables wherever possible * Prevent dismiss button from overlapping Banner text (#1850) * fix: add additional padding to dismissable banners * fix: make dismissable padding uniform * Update RTL spacing for tab icons (#1849) fix: update RTL spacing for tab icons * Fix div-inside-of-p issue in field errors (#1848) fix: make ScreenReaderText a span for semantics * feat(odyssey-icons): update all icon source SVGs * feat(odyssey-svgr): update template to support 24x24 sources * feat(odyssey-react-mui): generate new and updated icon components * feat(odyssey-react-mui): manually update icon index, update references in styling * docs(odyssey-storybook): update stories to use new icons * chore(odyssey-icons): update source/figma * chore(odyssey-react-mui): update icon components and index * chore(odyssey-storybook): update icon stories * chore: update external link icon * refactor(odyssey-react-mui): component Link now uses ExternalLinkIcon * chore: add pseudo-loc languages and fix locale inconsistency (#1851) * chore(odyssey-react-mui): change dash to underscore to align with other react locale format * chore: add ok-PL ok-SK language suppport * chore: updating README * chore: update naming for all icons * fix: add tooltip play test (#1854) * fix: add playwright tests for tabs, tooltip, banner, autocomplete * Translations for odyssey (#1856) chore(odyssey-react-mui): translations for odyssey-react-mui.properties * Add DataGrid (unstyled) (#1808) * fix: add material-react-table * fix: upgraded Prettier * feat: added DataGrid * fix: added tsbuildinfo to speed up TS compiles * fix: removed unused dependencies from Storybook * fix: updated DataGrid story for Storybook v7 * feat: updated DataGrid with more functionality * fix: added notes to DataGrid and commented out Reports * fix: removed unused imports from DataGrid * fix: upgraded material-react-table * fix: removed unsused comment in DataGrid * fix: split DataGrid into 2 components * fix: added translation interpolation and plurality * feat: added PaginatedDataGrid * fix: minor alphabetization in Select * fix: pagination works now in DataGrid * fix: removed InfinitelyScrolledDataGrid * fix: minor code positioning * fix: renamed DataGrid to DataTable * fix: renamed table and fixed checkboxes * fix: removed unused DataGrid component * fix: incorrectly named i18nKey values * fix: removed old Table stories * fix: stories using Table now use StaticTable * fix: incorrect children type in OdysseyTranslationProvider * fix: story imports use @storybook/blocks instead of @storybook/addon-docs/blocks * fix: missing Table components in RTL stories * fix: updated TokenTables to properly render new brand tokens * fix: removed unused import * fix: added console.error where we had console.log * fix: axe testing bug * Allow MenuButton to accept null children (#1847) refactor: add NullElement * Change all imports to be relative to `./` rather than from `./index.ts` (#1828) * refactor: make file paths absolute * refactor: make remaining file paths absolute * fix: commit suggestions from KG * refactor: update createTheme import * fix: update source of createTheme * refactor: change Alert imports to relative --------- Co-authored-by: Edbury Enegren <edbury.enegren@okta.com> * Ensure TagList can wrap (#1837) * fix: ensure TagList can wrap * feat: add isWrappable to TagList * refactor: make flexWrap the default * refactor(odyssey-react-mui): update TextInput styles to match brand * fix(odyssey-react-mui): lengthy field labels are no longer cut off * refactor(odyssey-react-mui): fix spacing in Select menu * refactor(odyssey-react-mui): restyle Select and Autocomplete for brand * fix(odyssey-react-mui): autocomplete is now RTL friendly * docs(odyssey-storybook): fix broken Autocomplete.Loading story * docs: update docs for Supernova (#1821) * docs: update docs for Supernova * fix: change type of endIcon in controls * refactor: make Button default to primary * feat: switch args back to alphabetical * refactor: move icons into separate file * fix: fix merge conflicts * fix: fix type errors * refactor: apply recommended changes * feat: add docs for CircularProgress * feat: add Link docs * feat: add Icon docs * feat: add Dialog docs * feat: modify ScreenReaderText docs * feat: update Status documentation * feat: add Tooltip docs * feat: add Tag documentation * feat: add Tabs docs * feat: added MenuButton docs * feat: updated Typography docs * refactor: simplify DatePicker docs * feat: update Banner docs * feat: update docs for Infobox * feat: update Toast docs * feat: update Autocomplete docs * feat: update docs for TextField * feat: update Checkbox and CheckboxGroup docs * feat: update Radio and RadioGroup docs * feat: update Form and Fieldset docs * feat: update Select and NativeSelect docs * refactor: abstracted out type enums * fix: fix type errors in Toast stories * fix: remove click on disabled checkbox * refactor: commit KG suggestions * fix: add missing variant to Button * refactor: fix import relativity * refactor(odyssey-react-mui): make Button styling syntax consistent * refactor: simplify Select stories (#1867) * fix: Button's `tooltipText` needs to show on hover (#1817) * fix: not showing Button's tooltipText when the prop is passed * fix: minor ordering of properties in Tooltip stories * fix: some Tooltip position stories use Tag, not Button * refactor(odyssey-react-mui): replace all theme.spacing with spacing tokens * refactor(odyssey-react-mui): remove mui variables that have a token equivalent * refactor(odyssey-design-tokens): update token values for consistency * feat(odyssey-react-mui): update Button to match Rebrand * docs(odyssey-storybook): add Disabled states to Button stories * chore: update aria label * chore: update button colors per design review * refactor: remove forwardRef on Link (#1863) * refactor(odyssey-react-mui): update Tab/Tabs styling * fix: add play test for dialog, menubutton, select, tag, passwordfield (#1861) * chore: update based on design feedback * chore: fix tests * chore: fix broken a11y test * feat(odyssey-react-mui): updated ScopedCSSBaseline for rebrand * chore: use "highlight" tokens * refactor: remove IconButton (#1865) * docs: add monolith to OdysseyTranslationProvider doc (#1866) * docs: add monolith to OdysseyTranslationProvider doc * Update packages/odyssey-storybook/src/guidelines/OdysseyTranslationProvider.stories.mdx Co-authored-by: Kevin Ghadyani <97464104+KevinGhadyani-Okta@users.noreply.github.com> * docs: expand on monolith docs --------- Co-authored-by: Kevin Ghadyani <97464104+KevinGhadyani-Okta@users.noreply.github.com> * Simplify Dialog children type (#1873) refactor: prevent children from being an array * Remove Icon type restriction from Button adornments (#1872) refactor: loosen type rules around Button adornments * feat(odyssey-react-mui): update Dialog to match Rebrand * chore: remove unnec import * chore: fix No Button state * chore: update Floating button bg * fix: Upgrade many packages to fix vulns (#1880) * fix: upgraded all packages * fix: datePickerTheme types * Remove all direct MUI exports (#1874) * refactor: remove all direct MUI exports * fix: update broken import * fix: update ThemeOptions import * fix: update additional broken imports * fix: move dep to devDep * chore: update yarn lock * refactor: re-add MUI exports to our library * refactor: make MenuItem use our own props (#1822) * refactor: make MenuItem use our own props * feat: add props to MenuItem * fix: update MenuItem API * refactor: commit KG suggestions * docs: add prop docs to MenuItem * fix: add NonNullable to fix broken type * chore: pull close button * refactor(odyssey-react-mui): remove borders from button:hover * Clean up props (#1868) * refactor: alphabetize all the things * docs: add full documentation to props * docs: add Field hasVisibleLabel prop * fix: adjust comment placement in Tooltip * refactor(odyssey-react-mui): remove remaining Theme variables from components file * docs: add RadioGroup isOptional explanation (#1890) * Change names of the Dialog footer props (#1887) refactor: change Dialog footer props * chore: update token naming after review * chore: update border main to control * chore: remove more theme vars * Moved Odyssey Labs into MUI (#1885) * feat: merged labs with mui * fix: import for MuiThemeDecorator * fix: removed README from labs/ export * fix: types export from labs * chore(deps): bump tough-cookie from 4.1.2 to 4.1.3 (#1871) Bumps [tough-cookie](https://github.com/salesforce/tough-cookie) from 4.1.2 to 4.1.3. - [Release notes](https://github.com/salesforce/tough-cookie/releases) - [Changelog](https://github.com/salesforce/tough-cookie/blob/master/CHANGELOG.md) - [Commits](salesforce/tough-cookie@v4.1.2...v4.1.3) --- updated-dependencies: - dependency-name: tough-cookie dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump semver from 5.7.1 to 5.7.2 (#1876) Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md) - [Commits](npm/node-semver@v5.7.1...v5.7.2) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump word-wrap from 1.2.3 to 1.2.4 (#1892) Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(odyssey-react-mui): make Form, Infobox spacing constent across uses * refactor: enable ARIA attributes on MenuButton (#1893) * Default Button text to empty string (#1883) refactor: default Button text to empty string * Add Odyssey clear button to SearchField (#1878) * feat: hide native clear button * feat: add custom button for search clear * docs: add proper docs to SearchField * Update packages/odyssey-react-mui/src/SearchField.tsx * refactor: add KG improvements * Update packages/odyssey-react-mui/src/SearchField.tsx * Update packages/odyssey-react-mui/src/SearchField.tsx * Update packages/odyssey-react-mui/src/SearchField.tsx * Wrap Box (#1891) * feat: wrap Box * refactor: use internal Box where possible * fix: add ref to wrapped Box * refactor: switch to material Box * Add StylisPlugins to OdysseyCacheProvider (#1898) * feat: adds ability to optionally add stylisPlugins * fix: refactors prop types in OdysseyProvider * Update README.md with new URL (#1901) * feat: add Button types (#1903) * docs: add kitchen sink to Button (#1902) * docs: add kitchen sink to Button * fix: add aria to icon-only button * Change Checkbox onChange and validity (#1895) * refactor: moving isValid to validity * feat: make component controlled * fix: use correct type for onChange * test: remove tests on certain checkbox states * refactor: cpation to subordinate * feat: adds ScopedCssBaseline to OdysseyThemeProvider (#1904) * Move Table to Labs (#1900) * refactor: move Table to Labs * fix: update broken types * refactor: remove Button prop changes * Require Button to have text, startIcon, or endIcon (#1899) * refactor: require Button to have text, startIcon, or endIcon * fix: fix broken types * refactor: update play types * Wrap Typography (#1886) * feat: wrap Typography * feat: add ARIA props to Typography * refactor: switch Typography to internal and add color * fix: update types * refactor: abstract component list into type * refactor: encapsulate component * refactor: update aliases * fix: modify vestigial Typogrpahy components * feat: remove Icon component (#1864) * feat: remove Icon component * docs: add explanatory description * fix: remove unnecessary type specificity * fix: remove unneeded invalid import * refactor: export icons and iconDictionary * fix: update icon imports * refactor: switch from iconDictionary to icons * refactor: make icons a separate export * fix: fix broken imports * fix: update broken import path * fix: add type fix * refactor: improve iconUtils * fix: update type * docs(odyssey-storybook): update Form, Fieldset content * Fixed icon index generation as well as renaming to .generated (#1906) * fix: icons get moved to dist/, not src/ * fix: updates Link target type to properly show all possible string values * fix: icons export in mui package.json * fix: moved devDependencies as dependencies in odyssey-svgr * fix: export for @okta/odyssey-react-mui/icons contains generated icons * fix: svg path optimization * Add OdysseyDesignTokensContext (#1908) * fix: icons get moved to dist/, not src/ * fix: updates Link target type to properly show all possible string values * fix: icons export in mui package.json * fix: moved devDependencies as dependencies in odyssey-svgr * fix: export for @okta/odyssey-react-mui/icons contains generated icons * fix: svg path optimization * fix: add OdysseyDesignTokensContext * refactor: rename "Infobox" to "Callout" * Translations for odyssey (#1909) chore(odyssey-react-mui): translations for odyssey-react-mui.properties * chore: typo fixes and sorting * feat: add `isDisabled` in context from Fieldset to Field (#1911) * Adds missing Tooltip functionality support to MenuButton and Status (#1912) * feat: add tooltipText to MenuButton * feat: rename `Button`'s `text` prop to `label * fix: refactored Button to use useMuiProps hook * feat: add Tooltip capabilities to Status * fix: button stories broken and menu button stories missing tooltip text * fix!: allow major version bumps (#1913) * Merge v1.0.0 into develop (#1915) Release/v1.0.0 (#1914) * refactor(odyssey-design-tokens): consolidate tokens, initial 2.0 work * refactor(odyssey-react-mui): refactor to use new tokens * refactor(odyssey-storybook): refactor to use new tokens * chore: pr feedback * refactor: update token names based on Content feedback * refactor: update typography tokens to match new values * fix(odyssey-storybook): match storybook ui to new tokens * chore: these keep popping up after build * docs(odyssey-storybook): update theming docs to use new tokens * Translations for odyssey (#1807) chore(odyssey-react-mui): translations for odyssey-react-mui.properties * fix: use odyssey tokens inside mui components style override * refactor(odyssey-design-tokens): rename "primary" type color to "action" * feat(odyssey-design-tokens): add "darker" to primary palette * feat(odyssey-react-mui): update Link to match new brand standards * feat(odyssey-react-mui): include color properties in type styles * refactor(odyssey-react-mui): migrate Circular Progress to design tokens * chore: fix hover/visited ordering * chore: same fix for monochrome variant * fix: add incremental to root tsconfig (#1810) fix: added incremental to root TSconfig * feat(odyssey-design-tokens): add border.radius.round * refactor(odyssey-design-tokens): caution to warning * refactor(odyssey-react-mui): convert MuiChip to odyssey tokens; find/replace all touched tokens * fix: memoize the Link component (#1813) fix: memoized the Link component * feat(odyssey-design-tokens): add border.width.heavy * feat(odyssey-react-mui): update Status styles and variants to match brand * docs(odyssey-storybook): update Status stories * feat(odyssey-design-tokens): add tokens for colorized text * refactor(odyssey-react-mui): apply colorized text tokens * chore: upgraded Applitools (#1815) * fix: change to DesignTokens type rather than the overrides in theme (#1816) * fix: changed to DesignTokens type rather than the overrides in theme creation * fix: incorrectly named property in Odyssey Storybook theme issue * chore(odyssey-design-tokens): update hue values * chore: rename indicator to variant * feat(odyssey-design-tokens): add 'disabled' type color * feat(odyssey-react-mui): add icon support to Tag * fix(odyssey-react-mui): add aria-disabled to Tag * chore: update Tag and Status styles based on design feedback * fix: orrectly import zh-CN and zh-TW files * refactor: remove isDefaultChecked and add isInvalid to Radio * refactor: remove vestigial isDefaultChecked from Checkbox * refactor: remove isDefaultValue from Radio * refactor: change hasError to isInvalid for Radio * refactor: make default Tooltip placement top * feat(odyssey-design-tokens): add border.outer and palette.x.heading * refactor(odyssey-react-mui): update all Alert styles to match rebrand * fix: enable a11y tests in CI (#1826) * fix: enable a11y tests in CI, add ariaLabel to components with accessibility violations * refactor(odyssey-react-mui): refactor alert title styling to enable variation * fix: Applitools VRT (#1827) fix: fixed Applitools config * feat(odyssey-design-tokens): add alpha tokens * feat(odyssey-react-mui): add transparency and blur to Toast * chore(odyssey-design-tokens): update alpha values to hex * docs(odyssey-storybook): make datepicker starting date fixed * chore: fix borderRadius on banner * chore(deps-dev): bump vite from 4.3.8 to 4.3.9 (#1819) Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 4.3.8 to 4.3.9. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v4.3.9/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: direct:development ... * fix: clicking MenuItem closes MenuButton (#1820) * fix: clicking MenuItem didn't close MenuButton * fix: incorrect prop name in MenuButton stories * Fix RTL position of chevron in NativeSelect (#1835) fix: adjust NativeSelect chevron position in RTL * Remove default branch in i18n config (#1841) * docs(odyssey-storybook): update Form stories to be more comprehensive * feat(odyssey-design-tokens): add token for border.radius.tight * feat(odyssey-react-mui): add sub2 type style * refactor(odyssey-react-mui): update Form and Fieldset styles to match brand * chore: add Checkbox to kitchen sink * fix: specfy accessibility tags section508, wcag21aa (#1839) * fix: specfy accessibility tags section508, wcag21aa * fix: a11y test for toast, typography, radio, checkbox * chore: update Field margin * RTL fixes for field labels (#1836) * fix: respect RTL in FormControlLabel children * fix: respect RTL in FormLabel optional text * refactor: replace margins with gap * refactor: remove vestigial display declaration * Enable button wrapping in Dialog footer (#1838) * feat: enable button wrapping in Dialog footer * refactor: improve Dialog footer specificity * Add missing displayNames to components (#1852) refactor: add missing displayNames * refactor(odyssey-react-mui): use component class name variables wherever possible * Prevent dismiss button from overlapping Banner text (#1850) * fix: add additional padding to dismissable banners * fix: make dismissable padding uniform * Update RTL spacing for tab icons (#1849) fix: update RTL spacing for tab icons * Fix div-inside-of-p issue in field errors (#1848) fix: make ScreenReaderText a span for semantics * feat(odyssey-icons): update all icon source SVGs * feat(odyssey-svgr): update template to support 24x24 sources * feat(odyssey-react-mui): generate new and updated icon components * feat(odyssey-react-mui): manually update icon index, update references in styling * docs(odyssey-storybook): update stories to use new icons * chore(odyssey-icons): update source/figma * chore(odyssey-react-mui): update icon components and index * chore(odyssey-storybook): update icon stories * chore: update external link icon * refactor(odyssey-react-mui): component Link now uses ExternalLinkIcon * chore: add pseudo-loc languages and fix locale inconsistency (#1851) * chore(odyssey-react-mui): change dash to underscore to align with other react locale format * chore: add ok-PL ok-SK language suppport * chore: updating README * chore: update naming for all icons * fix: add tooltip play test (#1854) * fix: add playwright tests for tabs, tooltip, banner, autocomplete * Translations for odyssey (#1856) chore(odyssey-react-mui): translations for odyssey-react-mui.properties * Add DataGrid (unstyled) (#1808) * fix: add material-react-table * fix: upgraded Prettier * feat: added DataGrid * fix: added tsbuildinfo to speed up TS compiles * fix: removed unused dependencies from Storybook * fix: updated DataGrid story for Storybook v7 * feat: updated DataGrid with more functionality * fix: added notes to DataGrid and commented out Reports * fix: removed unused imports from DataGrid * fix: upgraded material-react-table * fix: removed unsused comment in DataGrid * fix: split DataGrid into 2 components * fix: added translation interpolation and plurality * feat: added PaginatedDataGrid * fix: minor alphabetization in Select * fix: pagination works now in DataGrid * fix: removed InfinitelyScrolledDataGrid * fix: minor code positioning * fix: renamed DataGrid to DataTable * fix: renamed table and fixed checkboxes * fix: removed unused DataGrid component * fix: incorrectly named i18nKey values * fix: removed old Table stories * fix: stories using Table now use StaticTable * fix: incorrect children type in OdysseyTranslationProvider * fix: story imports use @storybook/blocks instead of @storybook/addon-docs/blocks * fix: missing Table components in RTL stories * fix: updated TokenTables to properly render new brand tokens * fix: removed unused import * fix: added console.error where we had console.log * fix: axe testing bug * Allow MenuButton to accept null children (#1847) refactor: add NullElement * Change all imports to be relative to `./` rather than from `./index.ts` (#1828) * refactor: make file paths absolute * refactor: make remaining file paths absolute * fix: commit suggestions from KG * refactor: update createTheme import * fix: update source of createTheme * refactor: change Alert imports to relative --------- * Ensure TagList can wrap (#1837) * fix: ensure TagList can wrap * feat: add isWrappable to TagList * refactor: make flexWrap the default * refactor(odyssey-react-mui): update TextInput styles to match brand * fix(odyssey-react-mui): lengthy field labels are no longer cut off * refactor(odyssey-react-mui): fix spacing in Select menu * refactor(odyssey-react-mui): restyle Select and Autocomplete for brand * fix(odyssey-react-mui): autocomplete is now RTL friendly * docs(odyssey-storybook): fix broken Autocomplete.Loading story * docs: update docs for Supernova (#1821) * docs: update docs for Supernova * fix: change type of endIcon in controls * refactor: make Button default to primary * feat: switch args back to alphabetical * refactor: move icons into separate file * fix: fix merge conflicts * fix: fix type errors * refactor: apply recommended changes * feat: add docs for CircularProgress * feat: add Link docs * feat: add Icon docs * feat: add Dialog docs * feat: modify ScreenReaderText docs * feat: update Status documentation * feat: add Tooltip docs * feat: add Tag documentation * feat: add Tabs docs * feat: added MenuButton docs * feat: updated Typography docs * refactor: simplify DatePicker docs * feat: update Banner docs * feat: update docs for Infobox * feat: update Toast docs * feat: update Autocomplete docs * feat: update docs for TextField * feat: update Checkbox and CheckboxGroup docs * feat: update Radio and RadioGroup docs * feat: update Form and Fieldset docs * feat: update Select and NativeSelect docs * refactor: abstracted out type enums * fix: fix type errors in Toast stories * fix: remove click on disabled checkbox * refactor: commit KG suggestions * fix: add missing variant to Button * refactor: fix import relativity * refactor(odyssey-react-mui): make Button styling syntax consistent * refactor: simplify Select stories (#1867) * fix: Button's `tooltipText` needs to show on hover (#1817) * fix: not showing Button's tooltipText when the prop is passed * fix: minor ordering of properties in Tooltip stories * fix: some Tooltip position stories use Tag, not Button * refactor(odyssey-react-mui): replace all theme.spacing with spacing tokens * refactor(odyssey-react-mui): remove mui variables that have a token equivalent * refactor(odyssey-design-tokens): update token values for consistency * feat(odyssey-react-mui): update Button to match Rebrand * docs(odyssey-storybook): add Disabled states to Button stories * chore: update aria label * chore: update button colors per design review * refactor: remove forwardRef on Link (#1863) * refactor(odyssey-react-mui): update Tab/Tabs styling * fix: add play test for dialog, menubutton, select, tag, passwordfield (#1861) * chore: update based on design feedback * chore: fix tests * chore: fix broken a11y test * feat(odyssey-react-mui): updated ScopedCSSBaseline for rebrand * chore: use "highlight" tokens * refactor: remove IconButton (#1865) * docs: add monolith to OdysseyTranslationProvider doc (#1866) * docs: add monolith to OdysseyTranslationProvider doc * Update packages/odyssey-storybook/src/guidelines/OdysseyTranslationProvider.stories.mdx * docs: expand on monolith docs --------- * Simplify Dialog children type (#1873) refactor: prevent children from being an array * Remove Icon type restriction from Button adornments (#1872) refactor: loosen type rules around Button adornments * feat(odyssey-react-mui): update Dialog to match Rebrand * chore: remove unnec import * chore: fix No Button state * chore: update Floating button bg * fix: Upgrade many packages to fix vulns (#1880) * fix: upgraded all packages * fix: datePickerTheme types * Remove all direct MUI exports (#1874) * refactor: remove all direct MUI exports * fix: update broken import * fix: update ThemeOptions import * fix: update additional broken imports * fix: move dep to devDep * chore: update yarn lock * refactor: re-add MUI exports to our library * refactor: make MenuItem use our own props (#1822) * refactor: make MenuItem use our own props * feat: add props to MenuItem * fix: update MenuItem API * refactor: commit KG suggestions * docs: add prop docs to MenuItem * fix: add NonNullable to fix broken type * chore: pull close button * refactor(odyssey-react-mui): remove borders from button:hover * Clean up props (#1868) * refactor: alphabetize all the things * docs: add full documentation to props * docs: add Field hasVisibleLabel prop * fix: adjust comment placement in Tooltip * refactor(odyssey-react-mui): remove remaining Theme variables from components file * docs: add RadioGroup isOptional explanation (#1890) * Change names of the Dialog footer props (#1887) refactor: change Dialog footer props * chore: update token naming after review * chore: update border main to control * chore: remove more theme vars * Moved Odyssey Labs into MUI (#1885) * feat: merged labs with mui * fix: import for MuiThemeDecorator * fix: removed README from labs/ export * fix: types export from labs * chore(deps): bump tough-cookie from 4.1.2 to 4.1.3 (#1871) Bumps [tough-cookie](https://github.com/salesforce/tough-cookie) from 4.1.2 to 4.1.3. - [Release notes](https://github.com/salesforce/tough-cookie/releases) - [Changelog](https://github.com/salesforce/tough-cookie/blob/master/CHANGELOG.md) - [Commits](salesforce/tough-cookie@v4.1.2...v4.1.3) --- updated-dependencies: - dependency-name: tough-cookie dependency-type: indirect ... * chore(deps): bump semver from 5.7.1 to 5.7.2 (#1876) Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md) - [Commits](npm/node-semver@v5.7.1...v5.7.2) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... * chore(deps): bump word-wrap from 1.2.3 to 1.2.4 (#1892) Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... * fix(odyssey-react-mui): make Form, Infobox spacing constent across uses * refactor: enable ARIA attributes on MenuButton (#1893) * Default Button text to empty string (#1883) refactor: default Button text to empty string * Add Odyssey clear button to SearchField (#1878) * feat: hide native clear button * feat: add custom button for search clear * docs: add proper docs to SearchField * Update packages/odyssey-react-mui/src/SearchField.tsx * refactor: add KG improvements * Update packages/odyssey-react-mui/src/SearchField.tsx * Update packages/odyssey-react-mui/src/SearchField.tsx * Update packages/odyssey-react-mui/src/SearchField.tsx * Wrap Box (#1891) * feat: wrap Box * refactor: use internal Box where possible * fix: add ref to wrapped Box * refactor: switch to material Box * Add StylisPlugins to OdysseyCacheProvider (#1898) * feat: adds ability to optionally add stylisPlugins * fix: refactors prop types in OdysseyProvider * Update README.md with new URL (#1901) * feat: add Button types (#1903) * docs: add kitchen sink to Button (#1902) * docs: add kitchen sink to Button * fix: add aria to icon-only button * Change Checkbox onChange and validity (#1895) * refactor: moving isValid to validity * feat: make component controlled * fix: use correct type for onChange * test: remove tests on certain checkbox states * refactor: cpation to subordinate * feat: adds ScopedCssBaseline to OdysseyThemeProvider (#1904) * Move Table to Labs (#1900) * refactor: move Table to Labs * fix: update broken types * refactor: remove Button prop changes * Require Button to have text, startIcon, or endIcon (#1899) * refactor: require Button to have text, startIcon, or endIcon * fix: fix broken types * refactor: update play types * Wrap Typography (#1886) * feat: wrap Typography * feat: add ARIA props to Typography * refactor: switch Typography to internal and add color * fix: update types * refactor: abstract component list into type * refactor: encapsulate component * refactor: update aliases * fix: modify vestigial Typogrpahy components * feat: remove Icon component (#1864) * feat: remove Icon component * docs: add explanatory description * fix: remove unnecessary type specificity * fix: remove unneeded invalid import * refactor: export icons and iconDictionary * fix: update icon imports * refactor: switch from iconDictionary to icons * refactor: make icons a separate export * fix: fix broken imports * fix: update broken import path * fix: add type fix * refactor: improve iconUtils * fix: update type * docs(odyssey-storybook): update Form, Fieldset content * Fixed icon index generation as well as renaming to .generated (#1906) * fix: icons get moved to dist/, not src/ * fix: updates Link target type to properly show all possible string values * fix: icons export in mui package.json * fix: moved devDependencies as dependencies in odyssey-svgr * fix: export for @okta/odyssey-react-mui/icons contains generated icons * fix: svg path optimization * Add OdysseyDesignTokensContext (#1908) * fix: icons get moved to dist/, not src/ * fix: updates Link target type to properly show all possible string values * fix: icons export in mui package.json * fix: moved devDependencies as dependencies in odyssey-svgr * fix: export for @okta/odyssey-react-mui/icons contains generated icons * fix: svg path optimization * fix: add OdysseyDesignTokensContext * refactor: rename "Infobox" to "Callout" * Translations for odyssey (#1909) chore(odyssey-react-mui): translations for odyssey-react-mui.properties * chore: typo fixes and sorting * feat: add `isDisabled` in context from Fieldset to Field (#1911) * Adds missing Tooltip functionality support to MenuButton and Status (#1912) * feat: add tooltipText to MenuButton * feat: rename `Button`'s `text` prop to `label * fix: refactored Button to use useMuiProps hook * feat: add Tooltip capabilities to Status * fix: button stories broken and menu button stories missing tooltip text * fix!: allow major version bumps (#1913) * build: bump versions for v1.0.0 * docs: update CHANGELOG for v1.0.0 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Edbury Enegren <36284167+edburyenegren-okta@users.noreply.github.com> Co-authored-by: Edbury Enegren <edbury.enegren@okta.com> Co-authored-by: ui-okta <33877894+ui-okta@users.noreply.github.com> Co-authored-by: Ganesh Somasundaram <ganesh.somasundaram@okta.com> Co-authored-by: François Lehoux <francois.lehoux@okta.com> Co-authored-by: Jordan Koschei <91091570+jordankoschei-okta@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Zihan Wang <57023248+zihanwang-okta@users.noreply.github.com> Co-authored-by: Queenie Chen <83596595+queeniechen-okta@users.noreply.github.com> * Launch day fixes (#1916) * refactor: move alert components out of folder * feat: add id to Box * fix: update fieldset description margins * docs: update the readmes * chore: upgrade storybook (#1917) * chore: upgrade storybook * chore: upgrade additional packages * Upgraded Lerna and conventional commit packages (#1919) * feat: upgrade Lerna to v7 * feat: upgrades commitlint cli * fix: upgrades commitlint plugins * feat: upgrades conventional-changelog-conventionalcommits * fix: removes lerna graduate commits * fix: fixes GitHub CI deploy failure on a11y * Merge v1.0.1 into develop (#1922) * fix: revert Odyssey bundle exports (#1920) fix: revert Odyssey exports changes * fix: broken styles in MuiInputBase (#1921) * build: bump versions for v1.0.2 * docs: update CHANGELOG for v1.0.2 * fix: update aria props passthrough * feat: memoize Box and Typography * feat: enable overflow and default MenuButton * fix: add back isDisabled to MenuItem * feat: add LTR-RTL button to support rtl languages (#1927) * feat: adds semgrep static scan to the repo (#1930) * fix(odyssey-react-mui): make Autocomplete option styles match Select * fix(odyssey-react-mui): make Autocomplete option focus a11y-compliant * chore: update hover colors on options * chore: update MenuItem option focus color to match hover * fix: remove useless isDestructive prop * Fix multi-select checkbox (#1931) fix: replace Select checkbox with MuiCheckbox * docs: update CustomTheming with correct example (#1932) * refactor(odyssey-react-mui): use IconButton within Form Fields * fix(odyssey-react-mui): ensure headings pick up TypographyFamilyHeading * fix: moves @emotion/styled and @emotion/react to dependencies (#1944) * fix: move @emotion/styled and @emotion/react to dependencies * fix: update README installation instructions * refactor: move ScopedCssBaseline to OdysseyProvider (#1940) * fix: adds branches back to Applitools (#1943) * fix: add branches back to Applitools * chore: testing branch name logging * fix: removed explicit baseline * fix: updated Applitools branch name --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Edbury Enegren <36284167+edburyenegren-okta@users.noreply.github.com> Co-authored-by: Edbury Enegren <edbury.enegren@okta.com> Co-authored-by: ui-okta <33877894+ui-okta@users.noreply.github.com> Co-authored-by: Ganesh Somasundaram <ganesh.somasundaram@okta.com> Co-authored-by: François Lehoux <francois.lehoux@okta.com> Co-authored-by: Jordan Koschei <91091570+jordankoschei-okta@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Zihan Wang <57023248+zihanwang-okta@users.noreply.github.com> Co-authored-by: Queenie Chen <83596595+queeniechen-okta@users.noreply.github.com> Co-authored-by: jordankoschei-okta <jordan.koschei@okta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat: add LTR-RTL button to support rtl languages
Screenshot
LTR
RTL