-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding mini.diff module as inline diff mechanism #210
Merged
Merged
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e50fa04
feat: adding mini.diff module
bassamsdata b2f5e02
fix: fixing the diff against original buffer
bassamsdata 77dff08
fix: safely call mini.diff plugin
bassamsdata bf1c10e
fix: safely check mini.diff, check if tests pass
bassamsdata a4d138d
feat: add diff_method to the config
bassamsdata f8853e3
docs: adding mini.diff to the README
bassamsdata 6f2b3c4
fix: rename miniDiff to mini_diff for consistency
bassamsdata File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,162 @@ | ||
local M = {} | ||
|
||
local api = vim.api | ||
local config = require("codecompanion").config | ||
local log = require("codecompanion.utils.log") | ||
|
||
local original_buffer_content = {} | ||
local codecompanion_buffers = {} | ||
local revert_timers = {} | ||
|
||
local function is_valid_buffer(buf_id) | ||
return buf_id and api.nvim_buf_is_valid(buf_id) | ||
end | ||
|
||
local function safe_get_lines(buf_id) | ||
if not is_valid_buffer(buf_id) then | ||
return {} | ||
end | ||
return api.nvim_buf_get_lines(buf_id, 0, -1, false) | ||
end | ||
|
||
local function set_diff_source(buf_id, source) | ||
if is_valid_buffer(buf_id) then | ||
vim.b[buf_id].diffCompGit = source | ||
end | ||
end | ||
|
||
local codecompanion_source = { | ||
name = "codecompanion", | ||
attach = function(buf_id) | ||
if not is_valid_buffer(buf_id) then | ||
return false | ||
end | ||
original_buffer_content[buf_id] = safe_get_lines(buf_id) | ||
set_diff_source(buf_id, "llm") | ||
return true | ||
end, | ||
detach = function(buf_id) | ||
original_buffer_content[buf_id] = nil | ||
set_diff_source(buf_id, "git") | ||
end, | ||
} | ||
|
||
local MiniDiff = require("mini.diff") | ||
local git_source = MiniDiff.gen_source.git() | ||
|
||
local function switch_to_codecompanion(buf_id) | ||
if not codecompanion_buffers[buf_id] then | ||
codecompanion_buffers[buf_id] = true | ||
MiniDiff.disable(buf_id) | ||
MiniDiff.enable(buf_id, { source = codecompanion_source }) | ||
M.update_diff(buf_id) | ||
set_diff_source(buf_id, "llm") | ||
end | ||
end | ||
|
||
local function switch_to_git(buf_id) | ||
if codecompanion_buffers[buf_id] then | ||
codecompanion_buffers[buf_id] = nil | ||
MiniDiff.disable(buf_id) | ||
MiniDiff.enable(buf_id, { source = git_source }) | ||
set_diff_source(buf_id, "git") | ||
end | ||
end | ||
|
||
local function schedule_revert_to_git(buf_id, delay) | ||
if revert_timers[buf_id] then | ||
revert_timers[buf_id]:stop() | ||
end | ||
revert_timers[buf_id] = vim.defer_fn(function() | ||
switch_to_git(buf_id) | ||
revert_timers[buf_id] = nil | ||
end, delay) | ||
end | ||
|
||
function M.start_diff(buf_id) | ||
switch_to_codecompanion(buf_id) | ||
M.update_diff(buf_id) | ||
end | ||
|
||
function M.accept(buf_id) | ||
M.update_diff(buf_id) | ||
local revert_delay = config.display.inline.diff.revert_delay or 5 * 60 * 1000 | ||
schedule_revert_to_git(buf_id, revert_delay) | ||
end | ||
|
||
function M.reject(buf_id) | ||
if original_buffer_content[buf_id] then | ||
api.nvim_buf_set_lines(buf_id, 0, -1, false, original_buffer_content[buf_id]) | ||
end | ||
switch_to_git(buf_id) | ||
end | ||
|
||
function M.update_diff(buf_id) | ||
if not is_valid_buffer(buf_id) then | ||
return | ||
end | ||
|
||
local current_content = safe_get_lines(buf_id) | ||
pcall(MiniDiff.set_ref_text, buf_id, original_buffer_content[buf_id] or {}) | ||
original_buffer_content[buf_id] = current_content | ||
end | ||
|
||
function M.force_git(buf_id) | ||
buf_id = buf_id or api.nvim_get_current_buf() | ||
switch_to_git(buf_id) | ||
end | ||
|
||
function M.force_codecompanion(buf_id) | ||
buf_id = buf_id or api.nvim_get_current_buf() | ||
if not is_valid_buffer(buf_id) then | ||
log:error("Invalid buffer ID") | ||
return | ||
end | ||
|
||
if not original_buffer_content[buf_id] then | ||
original_buffer_content[buf_id] = safe_get_lines(buf_id) | ||
end | ||
|
||
switch_to_codecompanion(buf_id) | ||
M.update_diff(buf_id) | ||
end | ||
|
||
function M.get_current_source(buf_id) | ||
buf_id = buf_id or api.nvim_get_current_buf() | ||
return vim.b[buf_id].diffCompGit or "git" | ||
end | ||
|
||
function M.setup() | ||
local revert_delay = config.display.inline.diff.revert_delay or 5 * 60 * 1000 | ||
|
||
api.nvim_create_autocmd("User", { | ||
pattern = "CodeCompanionInline*", | ||
callback = function(args) | ||
local buf_id = args.buf | ||
if not is_valid_buffer(buf_id) then | ||
return | ||
end | ||
|
||
if args.match == "CodeCompanionInlineStarted" then | ||
switch_to_codecompanion(buf_id) | ||
elseif args.match == "CodeCompanionInlineFinished" then | ||
local current_content = safe_get_lines(buf_id) | ||
pcall(MiniDiff.set_ref_text, buf_id, original_buffer_content[buf_id] or {}) | ||
original_buffer_content[buf_id] = current_content | ||
schedule_revert_to_git(buf_id, revert_delay) | ||
MiniDiff.toggle_overlay() | ||
end | ||
end, | ||
}) | ||
|
||
api.nvim_create_autocmd("BufReadPost", { | ||
callback = function(args) | ||
local buf_id = args.buf | ||
if is_valid_buffer(buf_id) and vim.b[buf_id].diffCompGit == nil then | ||
set_diff_source(buf_id, "git") | ||
end | ||
end, | ||
}) | ||
end | ||
|
||
return M |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should give users the choice of a provider i.e.
default
ormini_diff
. I think we should hardcode therevert_delay
in too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a setting called
config.display.inline.diff.diff_method
that can be set to eitherdefault
ormini_diff
. I'm not sure if this is what you asking for.I also removed the
revert_delay
setting and replaced it with a hardcoded value.