Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding transparency option to Lualine #221

Merged
merged 2 commits into from Jan 21, 2024
Merged

Adding transparency option to Lualine #221

merged 2 commits into from Jan 21, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jan 17, 2024

Lualine transparent TRUE

2024-01-17_164426_767701685

Lualine transparent FALSE or DEFAULT

2024-01-17_164355_826873704

@olimorris
Copy link
Owner

Thank you for the PR. Lualine is something that I neglect in this plugin as I use an alternative statusline.

A couple of asks:

  1. Could we move the config option to the options table and call it lualine_transparency. It fits in with where we keep the rest of the options for the plugin.
  2. Could you update the README.md's Default Configuration section to document this?

@ghost
Copy link
Author

ghost commented Jan 19, 2024

All done!

@olimorris olimorris merged commit edfc793 into olimorris:main Jan 21, 2024
2 of 3 checks passed
@olimorris
Copy link
Owner

Amazing! Really appreciated.

@olimorris olimorris mentioned this pull request Jan 22, 2024
Closed
5 tasks
@olimorris
Copy link
Owner

@cuencapm FYI, I forgot we turned this on by default in the config. I've turned it off in the latest commit so you'll need to turn it on manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@olimorris