Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace jest with vitest #173

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

lifeart
Copy link
Contributor

@lifeart lifeart commented Dec 5, 2024

Split for #167

Replacing jest with vitest to be able to properly test esmodules, including dependencies.

@ParthSareen
Copy link
Contributor

Awesome! Really appreciate this - going to review in the upcoming week and also tagging Bruce along for it!

Copy link
Collaborator

@BruceMacD BruceMacD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay on getting this in, I wasn't sure if it would be needed where I was hesitant to merge the additional image type PRs this went along with. I now see that this is a much better way to test the esm parts of the library.

@BruceMacD
Copy link
Collaborator

Going to merge this and fix CI in a follow-up.

@BruceMacD BruceMacD merged commit 1614f35 into ollama:main Jan 2, 2025
0 of 3 checks passed
@lifeart lifeart deleted the refactor-replace-jest-with-vitest branch January 5, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants