Feat/mig mysql spanner check gcpps09 37 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
November 6, 2024 12:12
taherkl
requested changes
Nov 18, 2024
| @@ -243,6 +243,10 @@ func ToSpannerIndexName(conv *Conv, srcIndexName string) string { | |||
| return getSpannerValidName(conv, srcIndexName) | |||
| } | |||
|
|
|||
| func ToSpannerCheckConstraintName(conv *Conv, srcCheckConstraintName string) string { | |||
| AutoGen ddl.AutoGenCol | ||
| Name string | ||
| Type Type | ||
| NotNull bool |
There was a problem hiding this comment.
What is the need for removing these spaces?
| @@ -115,6 +115,7 @@ func (is *InfoSchemaImpl) GenerateSrcSchema(conv *internal.Conv, infoSchema Info | |||
| table, e := is.processTable(conv, t, infoSchema) | |||
| mutex.Lock() | |||
| conv.SrcSchema[table.Id] = table | |||
|
|
|||
| @@ -185,7 +186,7 @@ func (is *InfoSchemaImpl) processTable(conv *internal.Conv, table SchemaAndName, | |||
| var t schema.Table | |||
| fmt.Println("processing schema for table", table) | |||
| tblId := internal.GenerateTableId() | |||
| primaryKeys, constraints, err := infoSchema.GetConstraints(conv, table) | |||
| primaryKeys, checkConstrainst, constraints, err := infoSchema.GetConstraints(conv, table) | |||
There was a problem hiding this comment.
checkConstrainst -> checkConstraints
| @@ -104,6 +104,7 @@ func (ss *SchemaToSpannerImpl) SchemaToSpannerDDLHelper(conv *internal.Conv, tod | |||
| ty, issues := toddl.ToSpannerType(conv, "", srcCol.Type, isPk) | |||
|
|
|||
| // TODO(hengfeng): add issues for all elements of srcCol.Ignored. | |||
| // if sr | |||
There was a problem hiding this comment.
Remove unnecessary comment
| droppedColumnSpMaxLength = 'MAX' | ||
| } | ||
|
|
| @@ -390,7 +453,7 @@ export class ObjectDetailComponent implements OnInit { | |||
| saveColumnTable() { | |||
| this.isEditMode = false | |||
| let updateData: IUpdateTable = { UpdateCols: {} } | |||
| let pgSQLToStandardTypeTypemap: Map<String, String>; | |||
| let pgSQLToStandardTypeTypemap: Map<String, String> | |||
There was a problem hiding this comment.
No need for lint changes if the code is not modified
| ToType: (this.conv.SpDialect === Dialect.PostgreSQLDialect) ? (standardDataType === undefined ? col.spDataType : standardDataType) : col.spDataType, | ||
| ToType: | ||
| this.conv.SpDialect === Dialect.PostgreSQLDialect | ||
| ? standardDataType === undefined |
There was a problem hiding this comment.
Please revert all the lint changes. Only show code changes done for the Check constraint feature
| } | ||
| this.dialog.open(InfodialogComponent, { | ||
| data: { | ||
| message: `Column ${spColName} is a part of${pkWarning}${commnaString}${indexWaring}${connectingString} check constrainst. Remove the dependencies from respective tabs before dropping the Column. `, |
There was a problem hiding this comment.
constrainst - constraints
Please perform a spell check on all the sentences/variables you have added.
added 7 commits
November 18, 2024 17:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #<issue_number_goes_here>