refactor: upgrade for Pydantic V2; upgrade Typer #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this able to be merged? |
omadson
changed the title
|
LGTM! |
@omadson Thanks! Anything I can do to help get this merged? Poetry install / tests run fine for me locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pydantic is now on V2 - adding fuzzy-c-means to a project that uses the current Pydantic will bring version conflicts.
I updated the pyproject.toml accordingly, then made a few necessary (minor) refactorings in the Pydantic syntax. Tests pass.
Finally, I ran isort/black on main.py - though it's likely worth swapping to use ruff in a future PR!