Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail with ome-zarr 0.8.3 #108

Closed
dstansby opened this issue May 19, 2024 · 4 comments · Fixed by #114
Closed

Tests fail with ome-zarr 0.8.3 #108

dstansby opened this issue May 19, 2024 · 4 comments · Fixed by #114

Comments

@dstansby
Copy link
Contributor

In #107 I had to pin the version of ome-zarr to get the tests to pass; this should be fixed so napari-ome-zarr works with the latest version of ome-zarr. A quick glance at the diff between version 0.8.2 and 0.8.3 doesn't reveal anything obvious to me that would have broke the tests here...

@dstansby
Copy link
Contributor Author

At a guess, ome/ome-zarr-py@c159b79 (#322) might be the culprit?

@psobolewskiPhD
Copy link
Contributor

Interesting, I can use the plugin ok with ome-zarr 0.8.3, with napari 0.4.19.
e.g. napari https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.4/idr0001A/2551.zarr/A/1/0
Here's the validation:
https://ome.github.io/ome-ngff-validator/?source=https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.4/idr0001A/2551.zarr/A/1/0/

@dstansby
Copy link
Contributor Author

dstansby commented Jun 6, 2024

CI at #93 shows the issues with ome-zarr 0.8.3. I think it's with the reader, not the writer - were you testing the writing part of the plugin?

@psobolewskiPhD
Copy link
Contributor

No, just reading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants