Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

78: check HAXM #103

Closed
wants to merge 16 commits into from
Closed

78: check HAXM #103

wants to merge 16 commits into from

Conversation

greenEkatherine
Copy link
Collaborator

No description provided.

@greenEkatherine
Copy link
Collaborator Author

@omen273 could you please provide an example of how better to add a timeout to the test classes?

@greenEkatherine greenEkatherine marked this pull request as ready for review March 22, 2021 20:50
@omen273
Copy link
Owner

omen273 commented Mar 22, 2021 •
edited
Loading

@omen273 could you please provide an example of how better to add a timeout to the test classes?

See BadCrosswordDataTest and retryTestRule. So add rule to existing base classes if it is possible

omen273
omen273 requested changes Mar 23, 2021
View reviewed changes
app/src/androidTest/java/com/example/crosswordToLearn/ChooseTopicsInstrumentedTest.kt Outdated Show resolved Hide resolved
app/src/androidTest/java/com/example/crosswordToLearn/Utils.kt Outdated Show resolved Hide resolved
azure-pipelines.yml Show resolved Hide resolved
azure-pipelines.yml Outdated Show resolved Hide resolved
omen273
omen273 requested changes Mar 28, 2021
View reviewed changes
Copy link
Owner

@omen273 omen273 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please invistigate the reason of failed tests

omen273
omen273 reviewed Mar 29, 2021
View reviewed changes
app/src/androidTest/java/com/example/crosswordToLearn/Utils.kt Outdated
class TestConstants
{
companion object {
const val TIMEOUT: Long = 30000;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use ms here instead of Long

@greenEkatherine
Copy link
Collaborator Author

moved to succesor PR #180

@omen273 omen273 deleted the check-haxm branch December 8, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omen273 omen273 omen273 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greenEkatherine @omen273