OMI_physics_body: Add explicit compound triggers instead of implicit ones #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronfranke
force-pushed
the
compound-triggers
branch
from
615b7f1
to
3cccdb7
Compare
aaronfranke
force-pushed
the
compound-triggers
branch
2 times, most recently
from
05afcef
to
3b66c10
Compare
aaronfranke
force-pushed
the
compound-triggers
branch
from
3b66c10
to
08755b8
Compare
lyuma
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds explicit compound triggers, specified by a new
"nodes"property under the"trigger"property inside of the"OMI_physics_body"extension on nodes. This replaces the old way of doing compound triggers, where a node containing"OMI_physics_body"with"trigger": {}was considered a compound trigger. Now, nodes are explicitly listed in the compound trigger node. This approach was discussed in the Khronos glTF meeting.This PR also includes some tweaks to the prose to clarify the behavior and usage of triggers.
The example file is expected to look like this after being imported into Godot (after my PR to implement this in Godot):
"Sister PR" to Microsoft/KHR to stay in sync with OMI: eoineoineoin/glTF_Physics#26
Godot implementation: godotengine/godot#88301