Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed templates for column filtering #348

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

thomasp-cnrs
Copy link

Original author: @kathibeepboop

fix #347

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.56%. Comparing base (6c3b3dc) to head (53ffabe).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #348   +/-   ##
=======================================
  Coverage   94.56%   94.56%           
=======================================
  Files          37       37           
  Lines         975      975           
=======================================
  Hits          922      922           
  Misses         53       53           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MIvanIsten
Copy link

Please consider to replace
{% if column.filter.placeholder != null %}
with
{% if column.filter.placeholder is not same as(null) %}
in Filter/select.html.twig

In twig != is not type safe
'' != null => false
'' is not same as(null) => true

@thomasp-cnrs
Copy link
Author

thomasp-cnrs commented Sep 2, 2024

@MIvanIsten thanks. I fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

So, what with column filters ?
2 participants