Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: links removed #2411

Merged
merged 7 commits into from
Jun 26, 2023
Merged

fix: links removed #2411

merged 7 commits into from
Jun 26, 2023

Conversation

sywhb
Copy link
Contributor

@sywhb sywhb commented Jun 22, 2023

  • skip removing <a> elements with published date in the url
  • better handle invalid url in puppeteer
  • check if the node has textContent before removing it

@vercel
Copy link

vercel bot commented Jun 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
omnivore-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2023 8:49am
omnivore-prod ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2023 8:49am

* skip removing <a> elements with published date in the url
@sywhb sywhb marked this pull request as ready for review June 26, 2023 04:02
@sywhb
Copy link
Contributor Author

sywhb commented Jun 26, 2023

Fix links removed in this web page: https://dg-docs.ole.dev/

@sywhb sywhb changed the title fix: links with published date are removed fix: links removed Jun 26, 2023
@sywhb sywhb merged commit 6d3989e into main Jun 26, 2023
@sywhb sywhb deleted the fix/readability-missing-links branch June 26, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants