Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fail to display the thumbnail of some webpages #4019

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Conversation

sywhb
Copy link
Contributor

@sywhb sywhb commented Jun 1, 2024

  • The current regex we use will match og:image:type for thumbnail url
  • Fix that by only matching og:image, og:image:url or og:image:secure_url

References: https://ogp.me/

* The regex we use is not strict and it will match og:image:type instead of og:image if there is one
Copy link

vercel bot commented Jun 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
omnivore-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 1, 2024 3:29am
omnivore-prod ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 1, 2024 3:29am

@sywhb sywhb changed the title fix: fail to display the thumbnail of some webpages * The regex we use is not strict and it will match og:image:type instead of og:image if there is one fix: fail to display the thumbnail of some webpages Jun 1, 2024
@sywhb
Copy link
Contributor Author

sywhb commented Jun 1, 2024

Fix #3970

@sywhb sywhb merged commit e64fee1 into main Jun 3, 2024
4 checks passed
@sywhb sywhb deleted the fix/thumbnail branch June 3, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants