Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DevASAN][CPU] bugfix for mmap return value check. #2402

Merged
merged 3 commits into from
Dec 26, 2024
Merged

[DevASAN][CPU] bugfix for mmap return value check. #2402

merged 3 commits into from
Dec 26, 2024
+3 −0

Conversation

yingcong-wu
Copy link
Contributor

@yingcong-wu yingcong-wu commented Dec 2, 2024 •
edited
Loading

mmap() would return MAP_FAILED instead of NULL in case of error, we need to do a translation here.

Intel/llvm PR: intel/llvm#16466

@yingcong-wu yingcong-wu requested a review from a team as a code owner December 2, 2024 08:39
@github-actions github-actions bot added the loader Loader related feature/bug label Dec 2, 2024
@yingcong-wu
Copy link
Contributor Author

Hi @aarongreig , could you help merge this fix? Thanks.

@aarongreig
Copy link
Contributor

Hi @aarongreig , could you help merge this fix? Thanks.

Happy to merge right away as it's a trivial change but I'll need you to make the LLVM PR to update the tag. I would do it myself but you can't approve your own PR and there wont be another UR reviewer around to approve until late next week

@yingcong-wu yingcong-wu mentioned this pull request Dec 24, 2024
Merged
@yingcong-wu
Copy link
Contributor Author

Hi @aarongreig , could you help merge this fix? Thanks.

Happy to merge right away as it's a trivial change but I'll need you to make the LLVM PR to update the tag. I would do it myself but you can't approve your own PR and there wont be another UR reviewer around to approve until late next week

Thank you, updated.

@aarongreig aarongreig merged commit 93fc133 into oneapi-src:main Dec 26, 2024
73 checks passed
@aarongreig
Copy link
Contributor

@yingcong-wu does this change need the 2025.1 label applied to it?

@AllanZyne
Copy link
Contributor

@yingcong-wu does this change need the 2025.1 label applied to it?

Yep, please add it. Thanks!

@aarongreig aarongreig added the v0.11.x Include in the v0.11.x release label Dec 27, 2024
dm-vodopyanov pushed a commit to intel/llvm that referenced this pull request Dec 27, 2024
@yingcong-wu @aarongreig
[UR][DeviceASAN] Bugfix for mmap (#16466)
092cd2d 
UR PR: oneapi-src/unified-runtime#2402

---------

Co-authored-by: Aaron Greig <aaron.greig@codeplay.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaomaosu zhaomaosu zhaomaosu approved these changes

@aarongreig aarongreig aarongreig approved these changes

@AllanZyne AllanZyne AllanZyne approved these changes

Assignees
No one assigned
Labels
loader Loader related feature/bug v0.11.x Include in the v0.11.x release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yingcong-wu @aarongreig @AllanZyne @zhaomaosu