[L0] Update L0 Init checking to print details in error log #2449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nrspruit
commented
Dec 11, 2024
nrspruit
commented
- Changed the L0 Init failures to goto the error log vs debug and always return an error to the error log if no init is possible.
- Enabled for calling zeParseError to generate the string of L0 error codes in all UR L0 code.
github-actions
bot
added
conformance
nrspruit
force-pushed
the
improve_l0_init_checking
branch
3 times, most recently
from
13cb355 to
a66e000
Compare
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Dec 12, 2024
-pre-commit PR for oneapi-src/unified-runtime#2449 Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
winstonzhang-intel
approved these changes
Dec 13, 2024
- Changed the L0 Init failures to goto the error log vs debug and always return an error to the error log if no init is possible. - Enabled for calling zeParseError to generate the string of L0 error codes in all UR L0 code. Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
nrspruit
force-pushed
the
improve_l0_init_checking
branch
from
a66e000 to
64ae812
Compare
nrspruit
added a commit
to nrspruit/llvm
that referenced
this pull request
Dec 13, 2024
-pre-commit PR for oneapi-src/unified-runtime#2449 Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
nrspruit
added
ready to merge
kbenzie
added a commit
that referenced
this pull request
Dec 16, 2024
[L0] Update L0 Init checking to print details in error log
sarnex
pushed a commit
to intel/llvm
that referenced
this pull request
Dec 16, 2024
Pulls in the following bug fixes: * oneapi-src/unified-runtime#2447 * oneapi-src/unified-runtime#2449 * oneapi-src/unified-runtime#2452 * oneapi-src/unified-runtime#2452 --------- Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com> Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.