Parameterize CTS tests across all available adapters and devices. #2479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ci/cd
aarongreig
force-pushed
the
aaron/parameterizeDeviceTests
branch
from
79a6543 to
ea58e4d
Compare
aarongreig
force-pushed
the
aaron/parameterizeDeviceTests
branch
3 times, most recently
from
b572dcb to
d881ba8
Compare
…-query Add UR_ADAPTER_INFO_VERSION query
The new `UUR_KNOWN_FAILURE_ON` macro can be used to skip tests on
devices where the test is known to fail. This can be done in the
following situations.
For all devices in an adapter:
```cpp
UUR_KNOWN_FAILURE_ON(uur::LevelZero{});
```
By substring match of the device name within and adapter:
```cpp
UUR_KNOWN_FAILURE_ON(uur::OpenCL{"Intel(R) UHD Graphics 770"});
```
> Note: This invocation is used in a few places in this patch to
> facilitate clean runs when using this decice.
In certain test suits, where there is no access to a device, the
platform name is used instead:
```cpp
UUR_KNOWN_FAILURE_ON(uur::CUDA{"NVIDIA CUDA BACKEND"});
```
When neither device or platform is available in a test suite, the name
is ignored and only the adapter backend is used to determine if the test
is a known failure.
The macro is variadic making it possible to specify known failures for
multiple adapters in a single place and multiple names can also be provided
per adapter:
```cpp
UUR_KNOWN_FAILURE_ON(
uur::OpenCL{
"Intel(R) UHD Graphics 750",
"Intel(R) UHD Graphics 770",
},
uur::HIP{"Radeon RX 7700"},
uur::NativeCPU{});
```
There are a couple left over: Where fails were specific to cfi config these will need to wait for a compile def so the KNOWN_FAILs can be ifdef'd The hip usm pool match entries just seem wrong, hip does have pool support so at least the basic pool tests should be passing. Suspect out of date match file, CI testing will validate
Also take out some loader specific known failures to see what happens.
aarongreig
force-pushed
the
aaron/parameterizeDeviceTests
branch
from
d881ba8 to
6a1d9ad
Compare
kbenzie
reviewed
Dec 20, 2024
Comment on lines
59
to
66
| UUR_KNOWN_FAILURE_ON(uur::CUDA{}); | ||
| UUR_KNOWN_FAILURE_ON(uur::HIP{}); | ||
| UUR_KNOWN_FAILURE_ON(uur::LevelZero{}); | ||
| UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{}); | ||
| UUR_KNOWN_FAILURE_ON(uur::NativeCPU{}); | ||
|
|
||
| UUR_KNOWN_FAILURE_ON(uur::OpenCL{"Intel(R) FPGA Emulation Device"}); | ||
| UUR_KNOWN_FAILURE_ON(uur::OpenCL{"Intel(R) UHD Graphics 770"}); |
There was a problem hiding this comment.
Could also be done like this:
Suggested change
| UUR_KNOWN_FAILURE_ON(uur::CUDA{}); | |
| UUR_KNOWN_FAILURE_ON(uur::HIP{}); | |
| UUR_KNOWN_FAILURE_ON(uur::LevelZero{}); | |
| UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{}); | |
| UUR_KNOWN_FAILURE_ON(uur::NativeCPU{}); | |
| UUR_KNOWN_FAILURE_ON(uur::OpenCL{"Intel(R) FPGA Emulation Device"}); | |
| UUR_KNOWN_FAILURE_ON(uur::OpenCL{"Intel(R) UHD Graphics 770"}); | |
| UUR_KNOWN_FAILURE_ON( | |
| uur::CUDA{}, | |
| uur::HIP{}, | |
| uur::LevelZero{}, | |
| uur::LevelZeroV2{}, | |
| uur::NativeCPU{}, | |
| uur::OpenCL{ | |
| "Intel(R) FPGA Emulation Device", | |
| "Intel(R) UHD Graphics 770", | |
| }, | |
| ); |
There was a problem hiding this comment.
have consolidated like this wherever possible, not sure about how the formatting ends up (it doesn't allow one per line) although that will improve when we mandate a linked issue (presumably that will lengthen each adapter entry and force them onto separate lines)
Also consolidate UUR_KNOWN_FAILURE_ON calls into one wherever there's multiple for the same test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.