Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hover scroll by keyboard #3804

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joseemds
Copy link
Contributor

I've been trying to add the command to scroll the hover popup, but i am stuck at how should i update HoverView, first i thought about exposing a HoverView.update function, but then how would i know the current value? Since the scroll is basically increase and decrease that value, in my mind the process is: Check if there is some active session, if so get the scrollTop value and update it depending on the command. My question is where should i expose the scrollTop value?

Please tell if there is something wrong in my logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant