Add --drop-axiom-annotations feature with value constraints #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesaoverton
requested changes
May 1, 2024
| @@ -1660,11 +1662,15 @@ public static void trimOntology(OWLOntology ontology) { | |||
| * @param ontology OWLOntology to remove axiom annotations | |||
| * @param properties Annotation property IRIs to remove related axiom annotations. | |||
| */ | |||
| public static void removeAxiomAnnotations(OWLOntology ontology, List<IRI> properties) { | |||
There was a problem hiding this comment.
This breaks a public interface by removing the method with this signature. We try hard to avoid that. Can the old method/signature (with List<IRI>) be maintained (maybe as a thin wrapper) while the new method (with Map<IRI, String>) is added?
jamesaoverton
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #886
docs/have been added/updatedmvn verifysays all tests passmvn sitesays all JavaDocs correctCHANGELOG.mdhas been updatedThis PR implements the last part of #886, which is to allow "value" expressions as constraints on the --drop-annotation-assertion parameter.
This does not at all affect the current behaviour on the
masterbranch, and is a bit incomplete compared to the more powerful selector inremoveandfilter: only exact values and regex constraints are supported, nothing else (in particular not constraints like<IRI>).mvn siteanymore: I get thousands of errors. Not sure why!