Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Elk to 0.6.0 in pom.xml #1201

Merged
merged 4 commits into from
May 28, 2024
Merged

Update Elk to 0.6.0 in pom.xml #1201

merged 4 commits into from
May 28, 2024

Conversation

matentzn
Copy link
Contributor

This PR adds and updated version of the Elk reasoner to ROBOT, see liveontologies/elk-reasoner#48 (comment).

  • docs/ have been added/updated (NA)
  • tests have been added/updated (Note needed)
  • mvn verify says all tests pass
  • mvn site says all JavaDocs correct
  • CHANGELOG.md has been updated

@ykazakov
Copy link

Are you sure you need elk-distribution-owlapi and not just elk-owlapi? Also, log4j was removed from ELK, so there is no need to exclude this dependency.

@matentzn
Copy link
Contributor Author

Are you sure you need elk-distribution-owlapi and not just elk-owlapi? Also, log4j was removed from ELK, so there is no need to exclude this dependency.

@ykazakov thanks for the comment. When I checked I think there was only "distribution", but most likely I was just blind. I changed it now, and it does work!

@jamesaoverton jamesaoverton merged commit 1fbb189 into master May 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants