Treat raw IRI as an OWLClass in logical template cells #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesaoverton
changed the title
balhoff
reviewed
Jul 31, 2024
| @@ -991,6 +991,14 @@ protected static OWLClassExpression tryParse( | |||
| // If we have a checker, try to get the class by label | |||
| // This allows class labels with single quotes | |||
| expr = checker.getOWLClass(content, false); | |||
| if (expr == null) { | |||
| // If not found by label, is it just an IRI? | |||
| IRI iri = IRI.create(content); | |||
There was a problem hiding this comment.
@jamesaoverton if someone enters a CURIE using an unknown prefix, is there a danger of turning it into an IRI here? In my experience OWL API will turn those into fake IRIs where the prefix becomes a scheme, e.g., "UNKNOWN:1234" -> <UNKNOWN:1234>. I find those mistakes really maddening (just speaking in general, not about robot template). Should you make some assumptions about IRIs here, such as only doing this if it starts with http:, https:, urn:, etc.?
There was a problem hiding this comment.
Good point. I agree.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ROBOT expects to see a class label or CURIE in a template cell, and it sees a raw IRI instead, interpret it as an OWLClass.
mvn verifysays all tests passCHANGELOG.mdhas been updatedThis is in response to a report on Slack.