create skeleton for adding indirect existentials in materialize #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matentzn
reviewed
Aug 15, 2024
|
|
||
|
|
||
|
|
||
| <!-- http://www.semanticweb.org/vinicius/ontologies/2024/7/untitled-ontology-2#has_part --> |
There was a problem hiding this comment.
These are very ugly IRIs, maybe run a string replace on the file to replace
http://www.semanticweb.org/vinicius/ontologies/2024/7/untitled-ontology-2
with something like
http://example.org/ontology
matentzn
reviewed
Aug 15, 2024
| @@ -44,6 +44,8 @@ public MaterializeCommand() { | |||
| o.addOption("o", "output", true, "save reasoned ontology to a file"); | |||
| o.addOption("t", "term", true, "a property to materialize"); | |||
| o.addOption("T", "term-file", true, "load properties from a file"); | |||
| o.addOption( | |||
There was a problem hiding this comment.
option should be "false" by default
matentzn
reviewed
Aug 15, 2024
| @@ -143,7 +169,7 @@ public static void materialize( | |||
| logger.debug("Excluding classes not in main ontology: " + c); | |||
| continue; | |||
| } | |||
| Set<OWLClassExpression> sces = emr.getSuperClassExpressions(c, true); | |||
| Set<OWLClassExpression> sces = emr.getSuperClassExpressions(c, !includeIndirect); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1213
docs/have been added/updatedmvn verifysays all tests passmvn sitesays all JavaDocs correctCHANGELOG.mdhas been updated