Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Align Bioportal and AgroPortal - part 2.1 - Add UI tests #24

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

syphax-bouazzouni
Copy link
Contributor

Require to be merged first

Context

This PR adds ui controller tests, to run do bin/ontoportal test

@syphax-bouazzouni syphax-bouazzouni changed the title Feature: Align Bioportal and AgroPortal - part 2 - Add UI tests Feature: Align Bioportal and AgroPortal - part 2.1 - Add UI tests Oct 12, 2024
@alexskr
Copy link
Contributor

alexskr commented Oct 21, 2024

  • The unit test for the ontologies controller walks all ontologies. While this is reasonable for most OntoPortal instances, it will create problems for BioPortal since it has a large number of ontologies, and some are not well-curated (broken). We need to add an option to pass in a list of specific ontologies against which to run the tests.
  • some of the tests are run for the functionality that is not yet present in this code base. Those tests should be disabled

@alexskr alexskr merged commit ddf72df into ontoportal:master Oct 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants