-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync with BioPortal release 6.20.0 and Alignement with Agroportal work #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pull request ontoportal#21 removed files that this class depends on. This is a temporary workaround until #337 is implemented.
Feature: Align Bioportal and AgroPortal - part 2.1 - Add UI tests
Feature: Align Bioportal and AgroPortal - part 2.2 and 3
Provide the ability to specify a list of ontologies to test instead of testing all ontologies. This is useful when testing APIs with a large number of ontologies.
…es_to_test Add option to test a specific set of ontologies
Dockerfile: * Change ruby image OS from Alpine to Debian slim-bookworm. Alpine is effective for reducing image size; however, using the slim version of Debian achieves a similar reduction. We can further reduce image size by adopting staged builds and moving Node/Yarn into a separate build stage. * Use ruby 3.2 * Removed docker binaries from the image. * Set bundler gem path to /usr/local/bundle docker-compose: * Add internal/external networks * Make node a non-runtime dependency * Do not expose ports for caching/db by default config: * Add development and test config files. Config files are redesigend to be used with .env so is safe to add
sample config file changes: - remove unused/obsolete settings like error email notifications, MAX_CHILDREN, MAX_POSSIBLE_DISPLAY and not yet implemented features - remove Google Analytics ID because it is moded to encypted credentials - use env variables with default values remove development and test config files, create them in docker image during build process.
…ts in app/javascript/controllers/index.js.
Enhance ontology change request attribution and begin UJS replacement
will add it back in seperate PR
Refactor: Docker
- use hash for theme colors, reduce repetition, simplify adding new theme - provide default theme in case $UI_THEME is missing
Merged as required to do the next part of the ncbo#338 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
sync-agroportal