Improve chat page performance (#3347)

* Simplify /manage/indexing-status * Rename endpoint
onyx-dot-app · Dec 5, 2024 · 3266ef6 · 3266ef6
1 parent c89b98b
commit 3266ef6
Show file tree

Hide file tree

Showing 7 changed files with 6 additions and 99 deletions.
diff --git a/backend/danswer/server/documents/connector.py b/backend/danswer/server/documents/connector.py
@@ -1010,37 +1010,18 @@ def get_connector_by_id(
 
 
 class BasicCCPairInfo(BaseModel):
-    docs_indexed: int
     has_successful_run: bool
     source: DocumentSource
 
 
-@router.get("/indexing-status")
+@router.get("/connector-status")
 def get_basic_connector_indexing_status(
     _: User = Depends(current_user),
     db_session: Session = Depends(get_session),
 ) -> list[BasicCCPairInfo]:
     cc_pairs = get_connector_credential_pairs(db_session)
-    cc_pair_identifiers = [
-        ConnectorCredentialPairIdentifier(
-            connector_id=cc_pair.connector_id, credential_id=cc_pair.credential_id
-        )
-        for cc_pair in cc_pairs
-    ]
-    document_count_info = get_document_counts_for_cc_pairs(
-        db_session=db_session,
-        cc_pair_identifiers=cc_pair_identifiers,
-    )
-    cc_pair_to_document_cnt = {
-        (connector_id, credential_id): cnt
-        for connector_id, credential_id, cnt in document_count_info
-    }
     return [
         BasicCCPairInfo(
-            docs_indexed=cc_pair_to_document_cnt.get(
-                (cc_pair.connector_id, cc_pair.credential_id)
-            )
-            or 0,
             has_successful_run=cc_pair.last_successful_index_time is not None,
             source=cc_pair.connector.source,
         )

diff --git a/web/src/components/initialSetup/search/NoCompleteSourceModal.tsx b/web/src/components/initialSetup/search/NoCompleteSourceModal.tsx
diff --git a/web/src/lib/assistants/fetchPersonaEditorInfoSS.ts b/web/src/lib/assistants/fetchPersonaEditorInfoSS.ts
@@ -26,7 +26,7 @@ export async function fetchAssistantEditorInfoSS(
   | [null, string]
 > {
   const tasks = [
-    fetchSS("/manage/indexing-status"),
+    fetchSS("/manage/connector-status"),
     fetchSS("/manage/document-set"),
     fetchSS("/llm/provider"),
     // duplicate fetch, but shouldn't be too big of a deal

diff --git a/web/src/lib/chat/fetchAssistantdata.ts b/web/src/lib/chat/fetchAssistantdata.ts
@@ -30,7 +30,7 @@ export async function fetchAssistantData(): Promise<AssistantData> {
 
     // Parallel fetch of additional data
     const [ccPairsResponse, llmProviders] = await Promise.all([
-      fetchSS("/manage/indexing-status").catch((error) => {
+      fetchSS("/manage/connector-status").catch((error) => {
         console.error("Failed to fetch connectors:", error);
         return null;
       }),

diff --git a/web/src/lib/chat/fetchChatData.ts b/web/src/lib/chat/fetchChatData.ts
@@ -52,7 +52,7 @@ export async function fetchChatData(searchParams: {
   const tasks = [
     getAuthTypeMetadataSS(),
     getCurrentUserSS(),
-    fetchSS("/manage/indexing-status"),
+    fetchSS("/manage/connector-status"),
     fetchSS("/manage/document-set"),
     fetchSS("/chat/get-user-chat-sessions"),
     fetchSS("/query/valid-tags"),

diff --git a/web/src/lib/chat/fetchSomeChatData.ts b/web/src/lib/chat/fetchSomeChatData.ts
@@ -70,7 +70,7 @@ export async function fetchSomeChatData(
   const taskMap: Record<FetchOption, () => Promise<any>> = {
     user: getCurrentUserSS,
     chatSessions: () => fetchSS("/chat/get-user-chat-sessions"),
-    ccPairs: () => fetchSS("/manage/indexing-status"),
+    ccPairs: () => fetchSS("/manage/connector-status"),
     documentSets: () => fetchSS("/manage/document-set"),
     assistants: fetchAssistantsSS,
     tags: () => fetchSS("/query/valid-tags"),
@@ -229,9 +229,7 @@ export async function fetchSomeChatData(
     result.shouldDisplaySourcesIncompleteModal =
       hasAnyConnectors &&
       !result.shouldShowWelcomeModal &&
-      !result.ccPairs.some(
-        (ccPair) => ccPair.has_successful_run && ccPair.docs_indexed > 0
-      ) &&
+      !result.ccPairs.some((ccPair) => ccPair.has_successful_run) &&
       (!user || user.role === "admin");
   }
 

diff --git a/web/src/lib/types.ts b/web/src/lib/types.ts
@@ -136,7 +136,6 @@ export interface ConnectorIndexingStatus<
 }
 
 export interface CCPairBasicInfo {
-  docs_indexed: number;
   has_successful_run: boolean;
   source: ValidSources;
 }