IAM Auth for RDS #3479
Merged
IAM Auth for RDS #3479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pablonyx
force-pushed
the
postgres_iam
branch
from
5a3de29 to
54ba454
Compare
backend/alembic/env.py
Outdated
| dialect: Any, conn_rec: Any, cargs: Any, cparams: Any | ||
| ) -> None: | ||
| if USE_IAM_AUTH: | ||
| region = os.getenv("AWS_REGION", "us-east-2") |
There was a problem hiding this comment.
seems a bit sketchy to hardcode this
There was a problem hiding this comment.
Good catch! Meant to put in configs
| @@ -300,7 +314,7 @@ services: | |||
| max-file: "6" | |||
|
|
|||
| indexing_model_server: | |||
| image: onyxdotapp/onyx-model-server:${IMAGE_TAG:-latest} | |||
| image: onyxdotapp/onyx-model-server-indexing:${IMAGE_TAG:-latest} | |||
There was a problem hiding this comment.
are the extra indent spaces here a glitch or intentional?
rkuo-danswer
approved these changes
Dec 17, 2024
aronszanto
pushed a commit
to aronszanto/onyx
that referenced
this pull request
Dec 23, 2024
* k * functional iam auth * k * k * improve typing * add deployment options * cleanup * quick clean up * minor cleanup * additional clarity for db session operations * nit * k * k * update configs * docker compose spacing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/danswer/issue/DAN-1190/iam-auth-for-the-postgres-database-aws-aurora-specifically
How Has This Been Tested?
Accepted Risk (provide if relevant)
N/A
Related Issue(s) (provide if relevant)
N/A
Mental Checklist:
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.