Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update citations in shared chat display #3487

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Update citations in shared chat display #3487

merged 4 commits into from
Dec 20, 2024

Conversation

pablonyx
Copy link
Contributor

@pablonyx pablonyx commented Dec 17, 2024 •
edited
Loading

Description

  • Pass documents to AI Message component in shared chat display
  • Update props to be stricter for AI Message

How Has This Been Tested?

On mobile, desktop:

  • Create shared chat
  • View doc results
  • Hover citations
Screenshot 2024-12-19 at 1 36 51 PM Screenshot 2024-12-19 at 1 36 59 PM Screenshot 2024-12-19 at 1 36 27 PM Screenshot 2024-12-19 at 1 36 24 PM

Accepted Risk (provide if relevant)

N/A

Related Issue(s) (provide if relevant)

N/A

Mental Checklist:

  • All of the automated tests pass
  • All PR comments are addressed and marked resolved
  • If there are migrations, they have been rebased to latest main
  • If there are new dependencies, they are added to the requirements
  • If there are new environment variables, they are added to all of the deployment methods
  • If there are new APIs that don't require auth, they are added to PUBLIC_ENDPOINT_SPECS
  • Docker images build and basic functionalities work
  • Author has done a final read through of the PR right before merge

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)

@vercel Vercel
Copy link

vercel bot commented Dec 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 1:14am

yuhongsun96
yuhongsun96 approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@yuhongsun96 yuhongsun96 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind me

yuhongsun96
yuhongsun96 reviewed Dec 19, 2024
View reviewed changes
backend/.webui_secret_key Outdated
@@ -0,0 +1 @@
BKjOt0YKDcq5K7ax
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AHHH what is this? XD

@pablonyx pablonyx enabled auto-merge December 20, 2024 01:16
@pablonyx pablonyx added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 9011b8a Dec 20, 2024
12 of 13 checks passed
aronszanto pushed a commit to aronszanto/onyx that referenced this pull request Dec 23, 2024
@pablonyx @yuhongsun96
Update citations in shared chat display (onyx-dot-app#3487)
890838e 
* update shared chat display

* Change Copy

* fix icon

* remove secret!

---------

Co-authored-by: Yuhong Sun <yuhongsun96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuhongsun96 yuhongsun96 yuhongsun96 approved these changes

Assignees
No one assigned
Labels
Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pablonyx @yuhongsun96