Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure password validation errors propagate #3509

Merged
merged 5 commits into from
Dec 19, 2024
Merged

Ensure password validation errors propagate #3509

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a05eff3
ensure password validation errors propagate
pablonyx Dec 18, 2024
4936936
copy update
pablonyx Dec 18, 2024
9b7aa60
support o1
pablonyx Dec 18, 2024
91f574f
improve typing
pablonyx Dec 18, 2024
dc09367
Revert "support o1"
pablonyx Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions backend/onyx/auth/users.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
from datetime import timezone
from email.mime.multipart import MIMEMultipart
from email.mime.text import MIMEText
from typing import cast
from typing import Dict
from typing import List
from typing import Optional
Expand Down Expand Up @@ -228,6 +229,11 @@ async def create(
safe: bool = False,
request: Optional[Request] = None,
) -> User:
# We verify the password here to make sure it's valid before we proceed
await self.validate_password(
user_create.password, cast(schemas.UC, user_create)
)

user_count: int | None = None
referral_source = (
request.cookies.get("referral_source", None)
Expand Down
Loading