Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent other tests from interfering with existing google drive tests #3624

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

hagen-danswer
Copy link
Contributor

@hagen-danswer hagen-danswer commented Jan 7, 2025

Description

  • now the thing being tested for is determined by the prefix of the test for google drive tests. This is done to allow other tests to be performed without breaking the existing tests.

Backporting (check the box to trigger backport action)

Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.

  • This PR should be backported (make sure to check that the backport attempt succeeds)

Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
internal-search ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 10:51pm

Copy link
Contributor

@pablonyx pablonyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Let's just leave that comment we discussed

@hagen-danswer hagen-danswer merged commit 4ce24d6 into main Jan 7, 2025
11 of 13 checks passed
@hagen-danswer hagen-danswer deleted the deflake-gdrive-tests branch January 7, 2025 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants