Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initiate db then use it . New for every Connection #2

Open
tlejmi opened this issue Dec 17, 2018 · 1 comment
Open

initiate db then use it . New for every Connection #2

tlejmi opened this issue Dec 17, 2018 · 1 comment

Comments

@tlejmi
Copy link

tlejmi commented Dec 17, 2018

initiate db then use it .
I have to create a new object each time i want to connect to the store .

I think it better to implement Open / Close ... in order to have easy access and use .

this.Handle = LevelDBInterop.leveldb_open(options.Handle, name, out error);

@Odirb
Copy link
Member

Odirb commented Jan 10, 2019

You are probably right, but original project was designed this way. I'm sorry refactoring this is not in our schedule (if you can create pull request keeping backward compatibility i will integrate it in the project).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants