refactor: move clickhouseproxy to use generic ec2 module #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform Run Output 🤖Format and Style 🖌
|
| Pusher | @DecFox |
| Action | pull_request |
| Environment | dev |
| Workflow | .github/workflows/check_terraform.yml |
| Last updated | Fri, 17 Jan 2025 05:44:32 GMT |
3 tasks
Ansible Run Output 🤖Ansible Playbook Recap 🔍Ansible playbook output 📖
|
| Pusher | @DecFox |
| Action | pull_request |
| Working Directory | |
| Workflow | .github/workflows/check_ansible.yml |
| Last updated | Fri, 17 Jan 2025 05:44:44 GMT |
hellais
reviewed
Jan 16, 2025
|
This has been deployed. Since the oonimeasurements service was deployed as part of #58, this proxy now enables using using the new measurements ECS service in the dev environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff is the tf split of #119 and limits the terraform changes. We introduce a new ec2 module and configure the clickhouse proxy instance to use this module instead of having its own module.
Part of #110
Closes #141