Skip to content

Commit

Permalink
fix(oonimkall): make sure SoftwareName is set
Browse files Browse the repository at this point in the history
While there, make sure we log the check-in request and response
with `-v`, because otherwise 🀌🀌🀌🀌.

Both part of ooni/probe#2644.
  • Loading branch information
bassosimone committed Dec 12, 2023
1 parent d84729d commit 645cecb
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion internal/ooapi/checkin.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ func NewDescriptorCheckIn(
AcceptEncodingGzip: true, // we want a small response
Authorization: "",
ContentType: httpapi.ApplicationJSON,
LogBody: false, // we don't want to log psiphon config
LogBody: true,
MaxBodySize: 0,
Method: http.MethodPost,
Request: &httpapi.RequestDescriptor[*model.OOAPICheckInConfig]{
Expand Down
1 change: 1 addition & 0 deletions pkg/oonimkall/session.go
Original file line number Diff line number Diff line change
Expand Up @@ -467,6 +467,7 @@ func (sess *Session) CheckIn(ctx *Context, config *CheckInConfig) (*CheckInInfo,
ProbeASN: info.ASNString(),
ProbeCC: info.CountryCode,
RunType: model.RunType(config.RunType),
SoftwareName: config.SoftwareName,
SoftwareVersion: config.SoftwareVersion,
WebConnectivity: config.WebConnectivity.toModel(),
}
Expand Down

0 comments on commit 645cecb

Please sign in to comment.