Skip to content

Commit

Permalink
chore: minor changes before alpha release (#1601)
Browse files Browse the repository at this point in the history
  • Loading branch information
bassosimone authored May 14, 2024
1 parent 95478fb commit c1863b7
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 6 deletions.
2 changes: 1 addition & 1 deletion docs/releasing.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ version that is compatible with our dependencies.
We should additionally update the `toolchain` line inside of `go.mod` to use the
specific toolchain we want to use. (The `toolchain` mechanism was introduced by
Go 1.21.0 and it may be that we can now use just the `toolchain` instead of
using the `GOVERSIOn` file; this should eventually be investigated.)
using the `GOVERSION` file; this should eventually be investigated.)

After updating `GOVERSION` and `go.mod`, we need to update our stdlib forks:

Expand Down
2 changes: 1 addition & 1 deletion internal/experiment/tlsmiddlebox/syscall_unix.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ package tlsmiddlebox

import (
"net"
"syscall"
"strings"
"syscall"
)

// SetTTL sets the IP TTL field for the underlying net.TCPConn
Expand Down
2 changes: 1 addition & 1 deletion internal/experiment/tlsmiddlebox/syscall_windows.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ package tlsmiddlebox

import (
"net"
"syscall"
"strings"
"syscall"
)

// SetTTL sets the IP TTL field for the underlying net.TCPConn
Expand Down
3 changes: 0 additions & 3 deletions internal/webconnectivityalgo/calltesthelpers_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -235,9 +235,6 @@ func TestSessionCallWebConnectivityTestHelper(t *testing.T) {
})

t.Run("with two test helpers where the first one times out the connection and the second works", func(t *testing.T) {
// TODO(bassosimone): the utility of this test will become more obvious
// once we switch this specific test to using httpclientx.

// create a local test server1 that resets the connection after a ~long delay
server1 := testingx.MustNewHTTPServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
select {
Expand Down

0 comments on commit c1863b7

Please sign in to comment.