Skip to content

Commit

Permalink
fix(logx): log when an operation is starting
Browse files Browse the repository at this point in the history
Not logging when an operation is starting complicates reasoning
about how much time it took to fail, which is something that caused
issues investigating ooni/probe#2544.
  • Loading branch information
bassosimone committed Oct 9, 2023
1 parent 16f175b commit febe2bd
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions internal/logx/operation.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ func newOperationLogger(maxwait time.Duration, logger model.Logger, format strin
wg: &sync.WaitGroup{},
}
ol.wg.Add(1)
ol.logger.Infof("%s... started", ol.message)
go ol.maybeEmitProgress()
return ol
}
Expand Down

0 comments on commit febe2bd

Please sign in to comment.