Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More detailed uninstall link prompt string #411

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

More detailed uninstall link prompt string #411

wants to merge 1 commit into from

Conversation

sdsantos
Copy link
Collaborator

Closes #384

@sdsantos sdsantos requested a review from aanorbel January 22, 2025 12:44
aanorbel
aanorbel approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@aanorbel aanorbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like too many modified translations.

Was that intended?

@sdsantos
Copy link
Collaborator Author

Looks like too many modified translations.

Was that intended?

I modified all translations that included that string, I thought that was the plan? The rest of the changes were automatic whitespace changes.

@aanorbel
Copy link
Member

We can go ahead and merge. the other language files are generated so i think the content would be replaced when an update is made from transifex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanorbel aanorbel aanorbel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Sprint Planning
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run V2 - Update uninstall link confirmation dialog text, to include a mention about also deleting the results
2 participants
@sdsantos @aanorbel