Skip to content

Commit

Permalink
[PBI-1609]
Browse files Browse the repository at this point in the history
-workaround of an issue on Mac Safari where VPAID 2.0 video creative midrolls get stuck buffering
  • Loading branch information
aeng7 committed Mar 24, 2016
1 parent 85de9e4 commit 9ef7c51
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion js/ad_manager_vast.js
Original file line number Diff line number Diff line change
Expand Up @@ -590,6 +590,16 @@ OO.Ads.manager(function(_, $) {
this._slot = _createUniqueElement();
this._videoSlot = this.amc.ui.adVideoElement[0];

//PBI-1609: Midroll VPAID 2.0 ads get stuck buffering on Mac Safari if
//the VPAID creative does not call load() on the video. This is not
//observed when using the Video Suite Inspector

//Setting preload to auto seems to address this issue with our player
//TODO: Find the root cause behind this issue and address it
if (!OO.requiresSingleVideoElement && OO.isSafari) {
this._videoSlot.preload = "auto";
}

environmentVariables = _.extend({
slot: this._slot,
videoSlot: this._videoSlot,
Expand Down Expand Up @@ -878,7 +888,7 @@ OO.Ads.manager(function(_, $) {
if (isVPaid) {
//Since a VPAID 2.0 ad handles its own UI, we want the video player to hide its UI elements
this.amc.hidePlayerUi();
_getFrame();
_getFrame();
} else {
// For VPAID we can only set the skip offset when ad already started
initSkipAdOffset(adWrapper);
Expand Down

0 comments on commit 9ef7c51

Please sign in to comment.