Simpler code for custom rating display

opatry · May 15, 2024 · 9770a03 · 9770a03
1 parent 643d348
commit 9770a03
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 10 deletions.
diff --git a/content/index.html.erb b/content/index.html.erb
@@ -35,11 +35,8 @@ unless @items["/cover/#{book[:isbn]}.*"].nil?
       <td><%= book[:author] %></td>
       <td>
         <p aria-label="<%= book[:rating] %>" title="<%= book[:rating] %>" style="vertical-align: middle; text-align: center;">
-          <% book[:rating].times do |star_on| %>
-          <%= star_svg(filled: true) %>
-          <% end %>
-          <% (10 - book[:rating]).times do |star_off| %>
-          <%= star_svg(filled: false) %>
+          <% 10.times do |i| %>
+          <%= star_svg(filled: i < book[:rating]) %>
           <% end %>
         </p>
       </td>

diff --git a/layouts/book.html.erb b/layouts/book.html.erb
@@ -7,11 +7,8 @@
 <h4><%= @item[:author] %></h4>
 
 <p aria-label="<%= @item[:rating] %>" title="<%= @item[:rating] %>" style="vertical-align: middle;">
-<% @item[:rating].times do |star_on| %>
-<%= star_svg(filled: true) %>
-<% end %>
-<% (10 - @item[:rating]).times do |star_off| %>
-<%= star_svg(filled: false) %>
+<% 10.times do |i| %>
+<%= star_svg(filled: i < @item[:rating]) -%>
 <% end %>
 </p>