Update the build. #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Java 17 - Tycho 2.7.4 - Eclipse 2022-06 (4.24) Release repository - org.eclipse.jdt.ls.tp 1.14.0 for target platform - Remove tycho-packaging-plugin - Remove pack200 (removed in Java 14) Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
rgrunber
commented
Aug 29, 2022
Comment on lines
+78
to
+82
| <artifact> | ||
| <groupId>org.eclipse.jdt.ls</groupId> | ||
| <artifactId>org.eclipse.jdt.ls.tp</artifactId> | ||
| <version>${symbol_dollar}{jdt.ls.version}</version> | ||
| </artifact> |
There was a problem hiding this comment.
Maybe we should create a separate target file (and module) for this. vscode-pde would then support building it, which currently, is not the case.
There was a problem hiding this comment.
I would very much be in favor of this if vscode-pde is able to handle it then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roland Grunberg rgrunber@redhat.com
I pointed @shawn-hurley to this from https://github.com/eclipse/eclipse.jdt.ls/wiki/Contribute-an-extension-bundle and it's currently in a pretty broken state. Bintray is basically gone, but one can still build and install the archetype in the local repo and use it that way.
The only thing I can't get working are the tests. For some reason the tests fails to include the m2e bundles. They're optional (I suspect that's why) but optional deps shouldn't be skipped. Being optional is a separate bug in the JDT-LS manifest. It really should be a normal requirement in JDT-LS as we import it .