Backport of enhancements for invite only courses #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tecoholic
force-pushed
the
tecoholic/backport-of-invite-only-course-enrollment
branch
from
72ab43a
to
6e74b8b
Compare
Agrendalath
requested changes
May 26, 2023
There was a problem hiding this comment.
@tecoholic, could we remove this line to run all tests in our fork? We could also upstream this, as it doesn't match the behavior from other repositories (and doesn't make much sense, TBH).
|
@Agrendalath I have removed the 'master' gate for the CI. But I think the dependencies are a little outdated. Erroring out at So, I |
Agrendalath
approved these changes
May 29, 2023
There was a problem hiding this comment.
👍
- I tested this: I didn't test this, but the diff matches the upstream PR
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository: n/a
Agrendalath
deleted the
tecoholic/backport-of-invite-only-course-enrollment
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the backport of the enhancements added to edx-enterprise in openedx#1748
Testing Instructions
Follow the testing instructions from openedx#1745 and openedx#1748 to test things in a local devstack with the following changes:
open-release/nutmeg.masterof the destack and setOPENEDX_RELEASEenvvar as well.enterprise-catalogservice and apply the following patch and recreate themcatalog_devstack_nutmeg.master.patch.txt
Expected outcome
The errors seen for invite only course enrollments via the manage learner page shouldn't happen anymore and enrollments should go through.