fix: update compat #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CefBoud
force-pushed
the
CefBoud/BB-8594/fix-integration-tests
branch
from
27497c1
to
a26febb
Compare
Agrendalath
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
👍
- I tested this: checked that the CI is passing
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository: n/a
CefBoud
force-pushed
the
CefBoud/BB-8594/fix-integration-tests
branch
from
a26febb
to
00692a6
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes integration tests failure on the master branch due to change introduced in this commit on
edx-platform. The function derived_key was renamed to derive_key and moved. Its signature changed as well.