Alternative (Tip/Suggestion)

[jimmywarting]

I saw someone using this library and it was confusing to me at first glance of what it was doing.
Then i figured: Is until needed, are there alternative solutions? And there is...

This dose not do exactly the same thing until is doing, but you won't need any try/catch or dependencies with the Settle method.

const [{status, value}] = await Promise.allSettled([fetchUser(id)])

the output is either:

{ status: "fulfilled", value: user } // or
{ status: "rejected",  reason: Error('an error') }

So the signature changes a bit. instead of checking for an error object u would have to check if status is fulfilled or rejected or looking for/if the reason property exist

-  const [error, user] = await until(() => fetchUser(id))
+  const [{value: user, reason: error}] = await Promise.allSettled([fetchUser(id)])

if (error) {
  return handleError(error)
}

user.password = 'abc'
await user.$save()

[kettanaito]

Hey, @jimmywarting. This is a great suggestion!

The practical difference would be the array signature, as Promise.allSettled is designed to handle multiple asynchronous operations, while until is designed to handle a single async operation.

I'm not sure if I like the never-rejecting semantics of Promise.allSettled though. If I understand it correctly, .allSettled never rejects, while still returning a Promise, implying it has the .catch() callback that can still be assigned but will never be used. There may be some exceptions to this in the spec, though.

That being said, I'd recommend using Promise.allSettled when:

• You wish to await multiple independent asynchronous actions;
• And you wish to know the result/rejection reason for each async action individually.

In any other case I'd still resort to until for its simplicity.

[jimmywarting]

if you want to use until, then that's fine also. Not saying how you should write your code or suggesting that you change your until lib to use this method (cuz allSettle is much newer and not as available to all env.) it's just an advice for others who don't want to have a extra dependency

I do however see one micro optimization doe..., b/c this is inside of a try/catch

until/src/until.ts

Lines 8 to 10 in da91c0c

	const data = await promise().catch((error) => {
	throw error
	})

then u could just do: const data = await promise() without catch() the catch method dose nothing for you, could imagine that the stack trace would be shorter then and easier to read 😉

[kettanaito]

Yeah, your suggestion is perfectly valid.

I've answered about that extra .catch() block and why it's needed here #9 (comment). It's not redundant.

[jimmywarting]

☝️ interesting