Skip to content

Commit

Permalink
feat: remove node 16 (#875)
Browse files Browse the repository at this point in the history
<!-- Please use this template for your pull request. -->
<!-- Please use the sections that you need and delete other sections -->

## This PR
<!-- add the description of the PR here -->

Removes Node 16 as it is deprecated.

Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
Co-authored-by: Todd Baert <todd.baert@dynatrace.com>
  • Loading branch information
lukas-reining and toddbaert authored May 13, 2024
1 parent 9083df8 commit c1878e4
Show file tree
Hide file tree
Showing 8 changed files with 9 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/audit-pending-releases.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: 16
node-version: 18
registry-url: "https://registry.npmjs.org"
cache: 'npm'

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- uses: actions/setup-node@v4
with:
registry-url: 'https://registry.npmjs.org'
node-version: 16
node-version: 18
cache: 'npm'

- name: Install
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/pr-checks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ jobs:
strategy:
matrix:
node-version:
- 16.x
- 18.x
- 20.x

Expand Down Expand Up @@ -47,7 +46,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 16
node-version: 18
cache: 'npm'

- name: Install
Expand Down Expand Up @@ -80,4 +79,4 @@ jobs:
run: npm run build

- name: SDK e2e tests
run: npm run e2e
run: npm run e2e
2 changes: 1 addition & 1 deletion .github/workflows/release-please.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: 16
node-version: 18
registry-url: "https://registry.npmjs.org"
cache: 'npm'
- name: Build Packages
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
},
"homepage": "https://github.com/open-feature/js-sdk#readme",
"engines": {
"node": ">=16"
"node": ">=18"
},
"devDependencies": {
"@rollup/plugin-typescript": "^11.1.6",
Expand Down
2 changes: 1 addition & 1 deletion packages/nest/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ Capabilities include:

### Requirements

- Node.js version 16+
- Node.js version 18+
- NestJS version 8+

### Install
Expand Down
2 changes: 1 addition & 1 deletion packages/server/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@

### Requirements

- Node.js version 16+
- Node.js version 18+

### Install

Expand Down
2 changes: 1 addition & 1 deletion packages/server/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
},
"homepage": "https://github.com/open-feature/js-sdk#readme",
"engines": {
"node": ">=16"
"node": ">=18"
},
"peerDependencies": {
"@openfeature/core": "1.1.0"
Expand Down

0 comments on commit c1878e4

Please sign in to comment.