feat: implement tracking as per spec #1020
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddbaert
force-pushed
the
feat/tracking
branch
from
c7ae35a
to
c914326
Compare
toddbaert
commented
Sep 20, 2024
beeme1mr
reviewed
Sep 20, 2024
toddbaert
requested review from
moredip,
beeme1mr,
nicklasl,
askpt,
kinyoklion,
aepfli,
luizgribeiro,
lukas-reining and
thomaspoignant
moredip
reviewed
Sep 26, 2024
toddbaert
added a commit
that referenced
this pull request
Oct 16, 2024
Inspired by [this comment](#1020 (comment)) I've added a lint rule to enforce `import type`, and some additional package changes to add a `lint:fix`. The only changes I made manually here is to add the lint rule, and the package.json script. All the changes are auto-generated by the `lint:fix`. --------- Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
force-pushed
the
feat/tracking
branch
from
567b836
to
9a15354
Compare
aepfli
approved these changes
Oct 17, 2024
| }; | ||
| } | ||
|
|
||
| private shortCircuitIfNotReady() { |
There was a problem hiding this comment.
[suggestion] I am not sure if it makes sense to unify this method somewhere, as we use it in both implementations and if something changes, it will most likely also change here
There was a problem hiding this comment.
This is harder than it sounds because the server/web actually both use different enums since there's more types in client; it's doable but involves some "fun" generics and lambdas which are probably more trouble than the improvement is worth.
The `tracking API` enables the association of feature flag evaluations with subsequent actions or application states, in order to facilitate experimentation and analysis of the impact of feature flags on business objectives. Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
force-pushed
the
feat/tracking
branch
from
9a15354
to
dcdb631
Compare
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
|
This is ready for review now. |
beeme1mr
reviewed
Oct 17, 2024
beeme1mr
reviewed
Oct 17, 2024
beeme1mr
reviewed
Oct 17, 2024
beeme1mr
reviewed
Oct 17, 2024
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
beeme1mr
reviewed
Oct 21, 2024
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
beeme1mr
approved these changes
Oct 21, 2024
wichopy
reviewed
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📣 This was a draft for a while, but is now ready for review! 📣
This implements tracking as per spec, in the server, web, and react SDKs.
I don't think the Angular or Nest SDKs need specific implementations, but please advise (cc @luizgribeiro @lukas-reining).
Fixes: #1033
Fixes: #1034