fix(angular): fix race condition on initialization #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
beeme1mr
reviewed
Oct 21, 2024
|
Not a blocker for me, but if you can think of a quick test for this it might be good. |
toddbaert
approved these changes
Oct 21, 2024
beeme1mr
approved these changes
Oct 21, 2024
…licitly Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
lukas-reining
commented
Oct 21, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 21, 2024
🤖 I have created a release *beep* *boop* --- ## [0.0.5-experimental](angular-sdk-v0.0.4-experimental...angular-sdk-v0.0.5-experimental) (2024-10-21) ### 🐛 Bug Fixes * **angular:** fix race condition on initialization ([#1052](#1052)) ([12eaa97](12eaa97)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com> Co-authored-by: Todd Baert <todd.baert@dynatrace.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Fixes a race condition when the directive is first rendered.
Initially the initialization code in the constructor before the
@Inputs were bound to the variables.This meant that in some cases providers were called with
undefinedas flag key, which most providers accept, but for flipt-web the engine paniced due to the value beingunitinstead of a string.